As long as you are happy with the results, I'm good. Always nice to have an
excuse to dip back into Lucene. Just don't want you to feel over confident with
the code without proper testing of it - I coded to fix the broken tests rather
than taking the time to write a bunch more corner case tests
Thanks Mark! The new patch is working fine with the tests and a few more. If
you have particular test cases in mind, I'd be happy to add them.
Thanks,
Peter
On Mon, Jul 25, 2011 at 5:56 PM, Mark Miller wrote:
> Sorry Peter - I introduced this problem with some kind of typo type issue -
> I some
Sorry Peter - I introduced this problem with some kind of typo type issue - I
somehow changed an includeSpans variable to excludeSpans - but I certainly
didn't mean too - it makes no sense. So not sure how it happened, and surprised
the tests that passed still passed!
We could probably use even
Thanks Peter - if you supply the unit tests, I'm happy to work on the fixes.
I can likely look at this later today.
- Mark Miller
lucidimagination.com
On Jul 25, 2011, at 10:14 AM, Peter Keegan wrote:
> Hi Mark,
>
> Sorry to bug you again, but there's another case that fails the unit test
> (s
Hi Mark,
Sorry to bug you again, but there's another case that fails the unit test
(search within the second sentence), as shown here in the last test:
package org.apache.lucene.search.spans;
import java.io.Reader;
import org.apache.lucene.analysis.Analyzer;
import org.apache.lucene.analysis.To
The 3X patch works great, Mark! (how do you get your head around spans so
quickly after 2.5 years? :) )
Thanks,
Peter
On Thu, Jul 21, 2011 at 5:23 PM, Mark Miller wrote:
>
> I just uploaded a patch for 3X that will work for 3.2.
>
> On Jul 21, 2011, at 4:25 PM, Mark Miller wrote:
>
> > Yeah, it
I just uploaded a patch for 3X that will work for 3.2.
On Jul 21, 2011, at 4:25 PM, Mark Miller wrote:
> Yeah, it's off trunk - I'll submit a 3X patch in a bit - just have to change
> that to an IndexReader I believe.
>
> - Mark
>
> On Jul 21, 2011, at 4:01 PM, Peter Keegan wrote:
>
>> Does
Yeah, it's off trunk - I'll submit a 3X patch in a bit - just have to change
that to an IndexReader I believe.
- Mark
On Jul 21, 2011, at 4:01 PM, Peter Keegan wrote:
> Does this patch require the trunk version? I'm using 3.2 and
> 'AtomicReaderContext' isn't there.
>
> Peter
>
> On Thu, Jul
Does this patch require the trunk version? I'm using 3.2 and
'AtomicReaderContext' isn't there.
Peter
On Thu, Jul 21, 2011 at 3:07 PM, Mark Miller wrote:
> Hey Peter,
>
> Getting sucked back into Spans...
>
> That test should pass now - I uploaded a new patch to
> https://issues.apache.org/jira
Hey Peter,
Getting sucked back into Spans...
That test should pass now - I uploaded a new patch to
https://issues.apache.org/jira/browse/LUCENE-777
Further tests may be needed though.
- Mark
On Jul 21, 2011, at 9:28 AM, Peter Keegan wrote:
> Hi Mark,
>
> Here is a unit test using a versio
Hi Mark,
Here is a unit test using a version of 'SpanWithinQuery' modified for 3.2
('getTerms' removed) . The last test fails (search for "1" and "3").
package org.apache.lucene.search.spans;
import java.io.Reader;
import org.apache.lucene.analysis.Analyzer;
import org.apache.lucene.analysis.To
On Jul 20, 2011, at 7:44 PM, Mark Miller wrote:
>
> On Jul 20, 2011, at 11:27 AM, Peter Keegan wrote:
>
>> Mark Miller's 'SpanWithinQuery' patch
>> seems to have the same issue.
>
> If I remember right (It's been more the a couple years), I did index the
> sentence markers at the same positio
On Jul 20, 2011, at 11:27 AM, Peter Keegan wrote:
> Mark Miller's 'SpanWithinQuery' patch
> seems to have the same issue.
If I remember right (It's been more the a couple years), I did index the
sentence markers at the same position as the last word in the sentence. And I
think the limitation
It seems to me that to constrain the search to a sentence this way, you'd
have to override 'getPositionIncrementGap', which would then break phrase
searches across the field values (sentences).
Peter
On Wed, Jul 20, 2011 at 11:33 AM, wrote:
>
> I just parse the text into sentences and put those
I just parse the text into sentences and put those in a multi-valued field
and then search that.
On Wed, 20 Jul 2011 11:27:38 -0400, Peter Keegan
wrote:
> I have browsed many suggestions on how to implement 'search within a
> sentence', but all seem to have drawbacks. For example, from
>
http:/
15 matches
Mail list logo
