Re: RFR: 8187588: Error generating using JDK 9 javadoc against a JDK 8 source repository

2017-11-20 Thread Jonathan Gibbons
Mostly OK. Suggest removing repeated use of @modules. The first use of @modules is enough ... it can take a list of values, spread over multiple lines. 28 * @modules jdk.compiler/com.sun.tools.javac.api 29 * jdk.compiler/com.sun.tools.javac.main 30 * jdk.javadoc/jdk.

RFR: 8187588: Error generating using JDK 9 javadoc against a JDK 8 source repository

2017-11-20 Thread Kumar Srinivasan
Hello, Please review simple fix for [1] webrev at [2]. Thanks Kumar [1] https://bugs.openjdk.java.net/browse/JDK-8187588 [2] http://cr.openjdk.java.net/~ksrini/8187588/webrev.00/

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Robert Scholte
I guess so :) thanks, Robert ps. can you add the label apache-maven-found to the issues so we can easily follow progress? On Mon, 20 Nov 2017 21:33:33 +0100, Jonathan Gibbons wrote: Does this mean we have a secondary bug, that the error message you got said "package" when it meant "mo

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Jonathan Gibbons
Does this mean we have a secondary bug, that the error message you got said "package" when it meant "module"? -- Jon On 11/20/17 12:01 PM, Robert Scholte wrote: javadoc: error - No source files for package com.io7m.bugs.c

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Jonathan Gibbons
That seems like a bug that needs to be fixed. As well as applications, there are also service-provider modules, which deserve to be documented, but which may not export API. -- Jon On 11/20/17 12:01 PM, Robert Scholte wrote: Hi Jon, I've found the problem.  The issue is that the module des

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Robert Scholte
Hi Jon, I've found the problem. The issue is that the module descriptor of c doesn't export any packages. Considering c is an application, it makes sense because that code is not shared for third parties. But what if you are using javadoc as documentation of your code? Can this be solved *