Re: RFR:JDK-8190875:modules not listed in overview/index page

Hi Jon, Thanks for the review. I could have avoided having explicit side-file. updated webrev : http://cr.openjdk.java.net/~pmuthuswamy/8190875/webrev.02/ Thanks, Priya On 6/5/2018 3:51 AM, Jonathan Gibbons wrote: It seems weird to have a hybrid methodology, such that you have an explicit side

RFR 8204321: javadoc tests fail after JDK-8203780

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8204321 Webrev: http://cr.openjdk.java.net/~sundar/8204321/webrev.00/index.html Thanks, -Sundar

Re: Change in generated files for SE API docs, caused by change to not generate frames

2018/6/4 15:54:34 -0700, [email protected]: > TIL about Canonical link element and 301 redirects. You get to decide > whether to follow the joint advice of Google and Microsoft > https://en.wikipedia.org/wiki/HTTP_301#Search_engines Sure, a 301 would be preferable, but it’s not always easy to a

Re: Change in generated files for SE API docs, caused by change to not generate frames

The doclet already has code to generate redirect pages;  given the short time available for 11, I would prefer to go with what we have. Also, I'm not sure that we can generate a 301 redirect from within a static web page. -- Jon On 6/4/18 3:54 PM, Martin Buchholz wrote: TIL about Canonical

Re: Change in generated files for SE API docs, caused by change to not generate frames

TIL about Canonical link element and 301 redirects. You get to decide whether to follow the joint advice of Google and Microsoft https://en.wikipedia.org/wiki/HTTP_301#Search_engines On Mon, Jun 4, 2018 at 3:45 PM, Jonathan Gibbons < [email protected]> wrote: > > > On 06/04/2018 03:39

Re: Change in generated files for SE API docs, caused by change to not generate frames

On 06/04/2018 03:39 PM, [email protected] wrote: I don't know much about >search engines (!) but maybe there's metadata to tell search engines what >the canonical URL is (or maybe simply redirects are interpreted that way). Indeed, there is:https://en.wikipedia.org/wiki/Canonical_lin

Re: Change in generated files for SE API docs, caused by change to not generate frames

2018/6/4 14:17:47 -0700, Martin Buchholz : > On Mon, Jun 4, 2018 at 2:11 PM, [email protected] wrote: >> ... >> >> So, what are our options. >> >> 0. Do nothing. People, and search engines, will learn to use a URL >> ending in "api/" or "api/index.html" >> >> 1. Back out the change.

Re: RFR:JDK-8190875:modules not listed in overview/index page

It seems weird to have a hybrid methodology, such that you have an explicit side-file (overview.html) but you generate other (source) files on the fly. If you want to keep overview.html as a separate distinct file, it needs to have a full legal header. Yes, I know it is sorta-silly to have a 2

Re: RFR:8199893:the javadoc tool generates pages with a low constrast

OK On 06/03/2018 10:39 PM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review simple fix for https://bugs.openjdk.java.net/browse/JDK-8199893 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8199893/webrev.00/ Thanks, Priya

Re: RFR 8203780: javadoc should be updated to use jquery 1.12.4 and jszip v3.1.5

OK -- Jon On 06/04/2018 05:33 AM, Sundararajan Athijegannathan wrote: Please review fix for https://bugs.openjdk.java.net/browse/JDK-8203780 Webrev: http://cr.openjdk.java.net/~sundar/8203780/webrev.00/ Thanks, -Sundar

Re: Change in generated files for SE API docs, caused by change to not generate frames

On Mon, Jun 4, 2018 at 2:11 PM, Jonathan Gibbons < [email protected]> wrote: > JDK-8196202 [1] introduced a change to the javadoc tool (and because of > that, to the Java SE API documentation) such that frames are not generated > by default. > > This has had a deliberate but somewhat une

Change in generated files for SE API docs, caused by change to not generate frames

JDK-8196202 [1] introduced a change to the javadoc tool (and because of that, to the Java SE API documentation) such that frames are not generated by default. This has had a deliberate but somewhat unexpected consequence on the Java SE API docs, of getting "404: Not found" on URLs that explici

RFR 8203780: javadoc should be updated to use jquery 1.12.4 and jszip v3.1.5

Please review fix for https://bugs.openjdk.java.net/browse/JDK-8203780 Webrev: http://cr.openjdk.java.net/~sundar/8203780/webrev.00/ Thanks, -Sundar

Re: Fwd: Re: running javadoc against multiple modules

Thanks for that explanation, Jon. You are right, Derby builds one component at a time, adding previously compiled components onto the classpaths of later components. I'm afraid that I haven't figured out what other options to use alongside --patch-module: # error: module not found: org.test.

Re: Fwd: Re: running javadoc against multiple modules

Rick, I will have to set up a clone of your world, using the attachment you provided last week, to investigate this further. -- Jon On 6/2/18 8:12 AM, Rick Hillegas wrote: Thanks for that explanation, Jon. You are right, Derby builds one component at a time, adding previously compiled compo