Re: RFR: 8202462 : {@index} may cause duplicate labels

2018-08-28 Thread Jonathan Gibbons
DocFilesHandlerImpl.java OK. It's a bit of a shame to have to edit this file. In HtmlDOcletWriter, you added an overload for getTagletWriterInstance, but not for commentTagsToContent. HtmlDocletWriter.java 366: If you're going to add new javadoc comments, do it properly/correctly; don't jus

Re: RFR : 8209052: Low contrast in docs/api/constant-values.html

2018-08-28 Thread Jonathan Gibbons
Priya, I still don't completely understand the rationale for your proposal, and I guess the problem is we're trying to solve several problems at once here. 1. There's an accessibility problem for some styles 2. There's an inconsistency in the way that links are handled in some places ... som

Re: RFR: 8176453: Javadoc search: there are issues with generics in parameters

2018-08-28 Thread Jonathan Gibbons
Hannes, I suggest that we split the bug fix from the Selenium work. That being said, if you do split it, I think it would be good to see a copy of the API docs built with the patch, and to have a written description of how to verify the bug (on standard docs) and the fix (on the modified docs

Re: RFR: 8208484: color contrast issues in javadoc

2018-08-28 Thread Magnus Ihse Bursie
Looks good to me. The original css file was created by me, yes, but not much design work went into it. I think I just used a stripped-down version of formatting i found in some older html files, and converted it to a css file. /Magnus > 30 juli 2018 kl. 12:53 skrev Jonathan Gibbons : > > Th

building javadoc with modules

2018-08-28 Thread Justin Lee
I'm trying to run javadoc against the java9 src.zip and I have no idea how to handle the modules. Even if I go with the classic "javadoc @sources" approach I get an error about too many modules defined. I've tried a number of variations but I can't quite seem to crack that nut. My latest attempt

RFR: 8210047 : api/overview-summary.html contains content outside of landmark region

2018-08-28 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8210047 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8210047/webrev.00/ Thanks, Priya