Re: building javadoc with modules

2018-08-29 Thread Jonathan Gibbons
Justin, This ought to be simple, but as you discovered, it isn't. I tried to generate the docs using the JDK 10 src.zip, available here: https://download.java.net/openjdk/jdk10/ri/openjdk-10_src.zip After ou unzip the sources, the command ought to be as simple as something like the following:

Re: RFR : 8209052: Low contrast in docs/api/constant-values.html

2018-08-29 Thread Jonathan Gibbons
On 08/29/2018 12:15 AM, Priya Lakshmi Muthuswamy wrote: In other summary captions, don't see any links. So I didn't change that. Understood. Arguably this comes under the general cleanup heading, rather than needing to be fixed now. My point is that either we admit to the possibility of l

Re: RFR: 8176453: Javadoc search: there are issues with generics in parameters

2018-08-29 Thread Hannes Wallnöfer
Sorry, I didn’t think it was necessary. Here it is: http://cr.openjdk.java.net/~hannesw/8176453/webrev.03/ Hannes > Am 29.08.2018 um 16:27 schrieb Jonathan Gibbons : > > Are you going to post a reduced webrev, without the Selenium files? > > -- Jon > > > On 8/29/18 2:55 AM, Hannes Wallnöfer

Re: RFR: 8176453: Javadoc search: there are issues with generics in parameters

2018-08-29 Thread Jonathan Gibbons
Are you going to post a reduced webrev, without the Selenium files? -- Jon On 8/29/18 2:55 AM, Hannes Wallnöfer wrote: Thanks for the feedback, Jon. I uploaded the generated docs to: http://cr.openjdk.java.net/~hannesw/8176453/api/ It’s still uploading as I write this, but the search on the

Re: RFR: 8202462 : {@index} may cause duplicate labels

2018-08-29 Thread Priya Lakshmi Muthuswamy
Hi Jon, Thanks for the comment. updated webrev: http://cr.openjdk.java.net/~pmuthuswamy/8202462/webrev.01/ In ModuleWriterImpl, since we are writing to module summary, set the inSummary parameter to true. Regards, Priya On 8/29/2018 5:42 AM, Jonathan Gibbons wrote: DocFilesHandlerImpl.java

Re: RFR: 8176453: Javadoc search: there are issues with generics in parameters

2018-08-29 Thread Hannes Wallnöfer
Thanks for the feedback, Jon. I uploaded the generated docs to: http://cr.openjdk.java.net/~hannesw/8176453/api/ It’s still uploading as I write this, but the search on the index page is working. Try anything with '<' or '>' to test the fix, such as „map Am 29.08.2018 um 00:12 schrieb Jonathan

Re: RFR : 8209052: Low contrast in docs/api/constant-values.html

2018-08-29 Thread Priya Lakshmi Muthuswamy
Hi Jon, 2. There's an inconsistency in the way that links are handled in some places ... sometimes the same color is used for all pseudo-classes for the element (:link, :visited, :hover, :active) and sometimes different colors are used for (:link, :visited) vs (:hover, :active) Constants and us