Re: RFR: 8210047 : api/overview-summary.html contains content outside of landmark region

2018-08-30 Thread Jonathan Gibbons
On 08/28/2018 01:25 AM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8210047 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8210047/webrev.00/ Thanks, Priya Just because we don't use frames in the JDK API docs doesn't mean they

Re: RFR : 8209052: Low contrast in docs/api/constant-values.html

2018-08-30 Thread Jonathan Gibbons
OK On 08/29/2018 12:15 AM, Priya Lakshmi Muthuswamy wrote: Hi Jon, 2. There's an inconsistency in the way that links are handled in some places ... sometimes the same color is used for all pseudo-classes for the element (:link, :visited, :hover, :active) and sometimes different colors are use

Re: RFR: 8176453: Javadoc search: there are issues with generics in parameters

2018-08-30 Thread Jonathan Gibbons
OK On 08/29/2018 07:40 AM, Hannes Wallnöfer wrote: Sorry, I didn’t think it was necessary. Here it is: http://cr.openjdk.java.net/~hannesw/8176453/webrev.03/ Hannes Am 29.08.2018 um 16:27 schrieb Jonathan Gibbons : Are you going to post a reduced webrev, without the Selenium files? -- Jon

Re: building javadoc with modules

2018-08-30 Thread Jonathan Gibbons
Justin, It seems there are two forms of src.zip out in the wild. My previous response was based on using a src.zip that is essentially just a zip of the contents of appropriate OpenJDK repo. As such, it has top level directories like "make", "src", "test", and the src/ directory does not co

Re: building javadoc with modules

2018-08-30 Thread Jonathan Gibbons
Justin, To follow up on this some more, can you tell me where you are getting "the java9 src.zip" that you refer to? Or, if you can't recall, can you check the layout of the contents? Is it like this: openjdk/ADDITIONAL_LICENSE_INFO openjdk/ASSEMBLY_EXCEPTION openjdk/bin openjdk/c