Troubles with java11 docs

2018-09-26 Thread Martin Buchholz
I was trying to migrate to using the shiny https://docs.oracle.com/en/java/javase/11/ for all my documentation needs and ran into some troubles: Every year I complain about no one checking for dead links in the docs. Running a dead-link checker before a major release should be easy-peasy. E.g. in

Re: RFR: 8202628 : javadoc generates bad links in TestModules.java

2018-09-26 Thread Jonathan Gibbons
+1. I also verified this file has the only (remaining?) instances of the comment `@ignore JDK-8202628` -- Jon On 09/26/2018 02:19 AM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the minor test fix for https://bugs.openjdk.java.net/browse/JDK-8202628. https://bugs.openjdk.java.net/br

Re: RFR:8208531 : -javafx mode should be on by default when JavaFX is available

2018-09-26 Thread Jonathan Gibbons
On 09/25/2018 05:22 AM, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8208531 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8208531/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8208532/ Thanks, Priya BaseConfiguratio

Re: RFR: JDK-8210555: create --source --target synonyms for -source -target

2018-09-26 Thread Hannes Wallnöfer
Looks good to me. Hannes > Am 25.09.2018 um 22:22 schrieb Jonathan Gibbons : > > Please review a mostly-trivial change to add --source and --target as > synonyms for -source and -target in javac and javadoc. > > There's also some related test-cleanup. > > Here's a brief explanation of the chan

Re: RFR: 8202628 : javadoc generates bad links in TestModules.java

2018-09-26 Thread Hannes Wallnöfer
+1 Hannes > Am 26.09.2018 um 11:19 schrieb Priya Lakshmi Muthuswamy > : > > https://bugs.openjdk.java.net/browse/JDK-8202462

RFR: 8202628 : javadoc generates bad links in TestModules.java

2018-09-26 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review the minor test fix for https://bugs.openjdk.java.net/browse/JDK-8202628. https://bugs.openjdk.java.net/browse/JDK-8202462 ( {@index} may cause duplicate labels) actually fixes the duplicates Id issue report in the test. This change just removes the code which disables checkLi