Doh! I forgot to give a link to the updated webrev.
Updated webrev: http://cr.openjdk.java.net/~jjg/8211407/webrev.01/
-- Jon
On 10/03/2018 02:39 PM, Jonathan Gibbons wrote:
Jan,
Thanks, but ... regrettably, the fix was a bit too clever and failed
one of the javadoc tests
that had annotatio
Jan,
Thanks, but ... regrettably, the fix was a bit too clever and failed one
of the javadoc tests
that had annotations on a package declaration. It failed because javac
ended up trying
to add the annotations to the package twice, caused by calling
`.complete()` too soon.
So, this version is
Looks good to me.
Jan
On 3.10.2018 02:24, Jonathan Gibbons wrote:
Please review a small fix, and medium test, that fixes hundreds(!) of
broken
links in the JDK API documentation.
The broken links in question are generally all in the javax.swing.**
packages,
and are the "See Serialized Form" li
Nir,
The level of interest could be interesting. I do note that there is
more of a trend in
Java API design these days to use factory methods, e.g. the ".of(...)"
pattern so that
would lend weight to such a feature.
That being said, it would then come down to the level of design and
impleme
Hi Jon,
Thanks for the info.
If I bring it up on the Java subreddit and see what people say, would it
count as a measure for interest? How is "sufficient interest" evaluated,
more or less?
- Nir
On Wed, Oct 3, 2018 at 2:27 AM Jonathan Gibbons
wrote:
>
>
> On 10/02/2018 06:54 AM, Nir Lisker wr
