Re: Memory leak in jdk.javadoc.internal.doclets.toolkit.WorkArounds

2019-10-14 Thread Jonathan Gibbons
Followup in RFR: JDK-8231587: Memory leak in WorkArounds.serializedForms Jonathan Gibbons https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-October/001167.html -- Jon On 10/08/2019 01:43 PM, Florian Weimer wrote: * Jonathan Gibbons: I do not see any evidence of any additional leak,

RFR: JDK-8231587: Memory leak in WorkArounds.serializedForms

2019-10-14 Thread Jonathan Gibbons
Please review a simple fix, and some code cleanup, for a memory leak in javadoc. The leak was first noted by Florian in the mail thread here: https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-September/001142.html The primary part of the fix is (just) the removal of the unnecessary 'sta

Re: Feedback on javadoc UI changes

2019-10-14 Thread Jonathan Gibbons
To give some context for all this work ... The original motivation was to fix a mostly-internal issue, such that without some internal hackery and limitations, when clicking on a link, especially on a link to earlier in the page, the target of the link could end up "under" (obscured by) the fl

Re: Feedback on javadoc UI changes

2019-10-14 Thread John Rose
On Oct 11, 2019, at 8:08 AM, Hannes Wallnöfer wrote: > > Hi Stuart, thanks for addressing these finer usability issues. > > Yes, the animated transitions can feel weird when triggered by a small > scrolling movement. The behaviour that you prefer is called sticky > positioning. I did try to u