Hi Jon,
The changes look good to me. As I said in my previous review, the separation of
method and CSS class use is a big improvement.
The html.*Writer classes still make be a bit uneasy. Browsing through the
classes I found a number of unused methods, but that is not related to your
changese
Thanks for the review, Jon.
I uploaded a new webrev that includes some but not all of your suggestions. I
think we should do more in a separate cleanup, especially the one to put
IndexItem and SearchIndexItem in a single class hierarchy.
http://cr.openjdk.java.net/~hannesw/8237383/webrev.01/
Looks good to me.
-Sundar
On 02/04/20 8:27 pm, Hannes Wallnoefer wrote:
Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241982
Webrev: http://cr.openjdk.java.net/~hannesw/8241982/webrev.00/
This makes TestSearchScript.java run with GraalJS in addition to
Nashorn, and potentiall
I realised there’s a simpler solution to the problem. Instead of using a Set to
track packages with non-modular documentation we can just return the module
name that matches our internal model in #checkLinkCompatibility.
I also changed the JBS summary to „javadoc fails to link to docs with
non-
