Hannes,
Thanks,
On the renamed message that you mention ... the old test code was
broken, in a mildly funny way. Sorry for not mentioning it up front.
Initially, I changed the test as you might expect, and it started
failing. On investigation, the test method being used takes a regular
exp
Please review a small update to doclint to permit the use of '' and
'',
which are legal in HTML5, per the rules here:
https://html.spec.whatwg.org/multipage/syntax.html#start-tags
-- Jon
JBS: https://bugs.openjdk.java.net/browse/JDK-8247235
Webrev: http://cr.openjdk.java.net/~jjg/8247235/webrev
Hi Kumar,
It's hard to use preview features in javac/javadoc because of the
bootstrap N-1 problem,
but yes, DocCommentInfo could be a record; also Utils.Pair is only used
in option decoding
for `-linkoffline` and could/should be moved there.
I'd also like the review the use of 3 separate maps
Hi Jon,
Looks good.
Out of curiosity, is it worthwhile to replace DocCommentInfo with Record ?
There may be other places where these Pair-like containers were introduced in
the doclet and javadoc tool.
Kumar
On Jun 8, 2020, at 9:48 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>>
+1 for TestComparator
Kumar
On Jun 9, 2020, at 7:48 AM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
Maybe it would help to rename TestOrdering to TestComparators ...
-- Jon
On 6/9/20 1:33 AM, Hannes Wallnoefer wrote:
Hi Kumar,
Thanks a lot for the hint! It is sometimes har
Jon,
Having in mind my extremely limited experience with jdk.compiler, the code
change looks okay. However, the test could be even better: it would be cleaner
if the test were built around actual tags rather than tag trees. Otherwise, the
proposed test is of "grey-box" kind as it uses the fact
Maybe it would help to rename TestOrdering to TestComparators ...
-- Jon
On 6/9/20 1:33 AM, Hannes Wallnoefer wrote:
Hi Kumar,
Thanks a lot for the hint! It is sometimes hard to figure out where to put
tests, and TestOrdering is without doubt the right place here. I’ve already
pushed this, b
Looks good to me.
I can’t quite work out why the message in testExplicitBinaryModuleOnLegacyPaths
changes from module_not_found to module_not_found_on_sourcepath instead of
module_source_not_found, but it seems like the correct message in the context.
Hannes
> Am 06.06.2020 um 01:48 schrieb J
Hi Kumar,
Thanks a lot for the hint! It is sometimes hard to figure out where to put
tests, and TestOrdering is without doubt the right place here. I’ve already
pushed this, but I’ll file another issue to move the test with added checks for
ordering.
Hannes
> Am 08.06.2020 um 19:56 schrieb Ku
