Re: Dark mode for generated JavaDoc pages

2020-09-14 Thread Jonathan Gibbons
Hi, It's not an unreasonable suggestion; I have filed https://bugs.openjdk.java.net/browse/JDK-8253137 to track it. That being said, there's two possibilities here: 1. A custom stylesheet to be used for a specific project's API. There are command line options for javadoc to allow the default

Integrated: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Pavel Rappo
On Mon, 14 Sep 2020 09:09:11 GMT, Pavel Rappo wrote: > Yet another cleanup change that has accumulated during my work on > `DocCommentParser` and other javadoc-related areas of > compiler. This pull request has now been integrated. Changeset: e6a493ab Author:Pavel Rappo URL: https:/

Dark mode for generated JavaDoc pages

2020-09-14 Thread Nir Lisker
Hi, Dark mode has become very popular in the past few years. However, the html pages use a pure white background that is uncomfortable to read. Will it be possible to add an option for dark mode? I believe it only requires a new css file, and a cookie so that the browser remembers the local settin

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler [v2]

2020-09-14 Thread Vicente Romero
On Mon, 14 Sep 2020 16:12:18 GMT, Pavel Rappo wrote: >> Yet another cleanup change that has accumulated during my work on >> `DocCommentParser` and other javadoc-related areas of >> compiler. > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler [v2]

2020-09-14 Thread Pavel Rappo
> Yet another cleanup change that has accumulated during my work on > `DocCommentParser` and other javadoc-related areas of > compiler. Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: To address pull-request feedback, I removed 4 `ass

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Pavel Rappo
On Mon, 14 Sep 2020 14:56:39 GMT, Vicente Romero wrote: >> I was hoping to use the `assert` facility for the purposes it was designed >> for. That particular occurrence of `assert` >> as well as others in this pull request are about asserting that **our code** >> is being correct rather than in

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Vicente Romero
On Mon, 14 Sep 2020 14:08:50 GMT, Pavel Rappo wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java >> line 290: >> >>> 288: >>> 289: protected void inlineTag(ListBuffer list) { >>> 290: assert buf[bp] == '{' : buf[bp]; >> >> not sure that this i

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Pavel Rappo
On Mon, 14 Sep 2020 13:47:28 GMT, Vicente Romero wrote: >> Yet another cleanup change that has accumulated during my work on >> `DocCommentParser` and other javadoc-related areas of >> compiler. > > src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java > line 290: > >

Re: RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Vicente Romero
On Mon, 14 Sep 2020 09:09:11 GMT, Pavel Rappo wrote: > Yet another cleanup change that has accumulated during my work on > `DocCommentParser` and other javadoc-related areas of > compiler. src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 290: > 288: > 289:

RFR: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler

2020-09-14 Thread Pavel Rappo
Yet another cleanup change that has accumulated during my work on `DocCommentParser` and other javadoc-related areas of compiler. - Commit messages: - Misc. cleanup - Fixed an embarrassing typo in `{@docroot}`. (Yes, I know that "{@docroot}" is case-insensitive when passed on a co