[jdk17] Integrated: JDK-8259499: Handling type arguments from outer classes for inner class in javadoc

2021-07-13 Thread Hannes Wallnöfer
On Thu, 1 Jul 2021 13:50:25 GMT, Hannes Wallnöfer wrote: > This change adds support for generating HTML links to the type arguments of > enclosing classes when creating a link to an inner class. Previously, only a > link to the inner class was created and the type arguments were even omitted >

Re: [jdk17] RFR: JDK-8259499: Handling type arguments from outer classes for inner class in javadoc [v3]

2021-07-13 Thread Jonathan Gibbons
On Mon, 12 Jul 2021 16:52:31 GMT, Hannes Wallnöfer wrote: >> This change adds support for generating HTML links to the type arguments of >> enclosing classes when creating a link to an inner class. Previously, only a >> link to the inner class was created and the type arguments were even omitte

Re: [jdk17] RFR: JDK-8259499: Handling type arguments from outer classes for inner class in javadoc [v3]

2021-07-13 Thread Jonathan Gibbons
On Fri, 9 Jul 2021 15:26:18 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >> line 1082: >> >>> 1080: // Must be a class reference since refClass is not null >>> and refMemName is null. >>> 1081:

Re: RFR: JDK-8269774: doclint reports missing javadoc comments for JavaFX properties if the docs are on the property method

2021-07-13 Thread Kevin Rushforth
On Fri, 9 Jul 2021 19:17:04 GMT, Jonathan Gibbons wrote: > Please review a simple change to the code for generating docs for JavaFX > properties, in order to suppress an inappropriate > "missing comment" warning. > > The change is to use `hasDocCommentTree` instead of `getDocCommentTree`. > >

[jdk17] Integrated: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote: > This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra > standards a

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links [v2]

2021-07-13 Thread Magnus Ihse Bursie
On Tue, 13 Jul 2021 08:26:21 GMT, Erik Joelsson wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >> standa

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links [v2]

2021-07-13 Thread Erik Joelsson
> This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra > standards as this was missed in the original review of this file. R

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Fri, 9 Jul 2021 20:13:56 GMT, Jonathan Gibbons wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >> stan

Re: [jdk17] RFR: 8259848: Interim javadoc build does not support platform links

2021-07-13 Thread Erik Joelsson
On Mon, 12 Jul 2021 11:10:26 GMT, Magnus Ihse Bursie wrote: >> This patch adds copying of element-list files generated for jdk.javadoc to >> the interim langtools version of jdk.javadoc. I'm also refactoring the >> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra >> s