Re: RFR: 8266666: Implementation for snippets [v7]

2021-08-25 Thread Pavel Rappo
On Wed, 25 Aug 2021 21:50:34 GMT, Jonathan Gibbons wrote: > So you're just suggesting that I should handle the parts related to > tagletPath, right? If so, OK. Yes, I am. I have created a separate bug, where I suggested a patch: https://bugs.openjdk.java.net/browse/JDK-8273001 -

Re: RFR: 8266666: Implementation for snippets [v20]

2021-08-25 Thread Pavel Rappo
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which > hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge > of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets > branch. Pavel Rappo has updated the pull request incrementally

Re: RFR: 8266666: Implementation for snippets [v7]

2021-08-25 Thread Jonathan Gibbons
On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons wrote: >> Generally impressive piece of work. > >> @jonathan-gibbons, do we need to mention the semantic change to >> `com.sun.source.doctree.AttributeTree` in the release notes? Before this PR, >> `AttributeTree` used to only represent HTML at

Re: RFR: 8266666: Implementation for snippets [v7]

2021-08-25 Thread Pavel Rappo
On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons wrote: >> Generally impressive piece of work. > >> @jonathan-gibbons, do we need to mention the semantic change to >> `com.sun.source.doctree.AttributeTree` in the release notes? Before this PR, >> `AttributeTree` used to only represent HTML at

Re: RFR: JDK-8272375: Improve phrasing of synthesized descriptions in JavaFX docs

2021-08-25 Thread Kevin Rushforth
On Tue, 24 Aug 2021 20:54:08 GMT, Jonathan Gibbons wrote: > Please review a very simple change to the support for the synthesized method > descriptions in JavaFX. > > The change is just to change the order of words in generated descriptions > from > _the property `NAME`_ > to > _the `

RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules

2021-08-25 Thread Andrey Turbanov
Collections.sort is just a wrapper, so it is better to use an instance method directly. - Commit messages: - [PATCH] Replace usages of Collections.sort with List.sort call in jdk.* modules Changes: https://git.openjdk.java.net/jdk/pull/5230/files Webrev: https://webrevs.openjdk.j

Re: RFR: 8266666: Implementation for snippets [v19]

2021-08-25 Thread Pavel Rappo
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which > hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge > of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets > branch. Pavel Rappo has updated the pull request incrementally

Re: RFR: 8266666: Implementation for snippets [v18]

2021-08-25 Thread Pavel Rappo
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which > hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge > of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets > branch. Pavel Rappo has refreshed the contents of this pull re

Re: RFR: 8266666: Implementation for snippets [v16]

2021-08-25 Thread Pavel Rappo
On Wed, 25 Aug 2021 16:00:08 GMT, Pavel Rappo wrote: >> This PR implements JEP 413 "Code Snippets in Java API Documentation", which >> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge >> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets >> bran

Re: RFR: 8266666: Implementation for snippets [v17]

2021-08-25 Thread Pavel Rappo
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which > hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge > of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets > branch. Pavel Rappo has refreshed the contents of this pull re

Re: RFR: 8266666: Implementation for snippets [v16]

2021-08-25 Thread Pavel Rappo
> This PR implements JEP 413 "Code Snippets in Java API Documentation", which > hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge > of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets > branch. Pavel Rappo has updated the pull request incrementally