Integrated: Merge jdk18

2022-01-12 Thread Jesper Wilhelmsson
On Wed, 12 Jan 2022 23:32:00 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 67e3d51d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/67e3d51d68e7319bd6d5b01233b664e6ee6b17ec Stats: 907 l

RFR: Merge jdk18

2022-01-12 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18 - 8206181: ExceptionInInitializerError: improve handling of exceptions in user-provided taglets - 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegati

Re: RFR: JDK-8234682: The order of @param in the generated docs should match the method signature

2022-01-12 Thread Hannes Wallnöfer
On Wed, 12 Jan 2022 17:04:04 GMT, Jonathan Gibbons wrote: > > It would be helpful if the order of the @param tags in the source was > > matched the declaration. > > Can a warning be generated if the @param tags are out of order? > > That seems like a good suggestion, for a different PR. The obv

Re: RFR: JDK-8234682: The order of @param in the generated docs should match the method signature

2022-01-12 Thread Hannes Wallnöfer
On Wed, 12 Jan 2022 15:32:40 GMT, Roger Riggs wrote: > It would be helpful if the order of the @param tags in the source was matched > the declaration. Can a warning be generated if the @param tags are out of > order? I think it is worth considering. Does it have to be a warning or would an i

Re: RFR: JDK-8234682: The order of @param in the generated docs should match the method signature

2022-01-12 Thread Jonathan Gibbons
On Wed, 12 Jan 2022 17:03:32 GMT, Hannes Wallnöfer wrote: > It would be helpful if the order of the @param tags in the source was matched > the declaration. > Can a warning be generated if the @param tags are out of order? That seems like a good suggestion, for a different PR. The obvious plac

Re: RFR: JDK-8234682: The order of @param in the generated docs should match the method signature

2022-01-12 Thread Roger Riggs
On Wed, 12 Jan 2022 08:40:08 GMT, Hannes Wallnöfer wrote: > Please review a change in how documentation from `@param` tags is generated. > > The old code generates parameter documentation for each `@param` in the order > in which the tags occur in the comment, then adds documentation from > i

RFR: JDK-8234682: The order of @param in the generated docs should match the method signature

2022-01-12 Thread Hannes Wallnöfer
Please review a change in how documentation from `@param` tags is generated. The old code generates parameter documentation for each `@param` in the order in which the tags occur in the comment, then adds documentation from inherited `@param` tags for undocumented parameters. The new code alw