Re: RFR: 8284697: Avoid parsing the doc comment of an element that is not documented

2022-04-15 Thread Pavel Rappo
On Fri, 15 Apr 2022 19:56:21 GMT, Pavel Rappo wrote: > > Does this need a jmh benchmark? > > I'm not sure how to compare "before" and "after" meaningfully here. Generally > speaking, I was satisfied when saw that `time` output stayed the same on my > machine; maybe only a few seconds

Re: RFR: 8284697: Avoid parsing the doc comment of an element that is not documented

2022-04-15 Thread Pavel Rappo
On Fri, 15 Apr 2022 19:08:20 GMT, XenoAmess wrote: > Does this need a jmh benchmark? I'm not sure how to compare "before" and "after" meaningfully here. Generally speaking, I was satisfied when saw that `time` output stayed the same on my machine; maybe only a few seconds different on a

Re: RFR: 8284697: Avoid parsing the doc comment of an element that is not documented

2022-04-15 Thread XenoAmess
On Fri, 15 Apr 2022 18:23:38 GMT, Pavel Rappo wrote: > We shouldn't parse comments that are going to be thrown away. > > Although the change is simple, I have no idea on how to test it. So I'm > tempted to affix the "noreg-other" or "noreg-hard" label on the JBS issue. Does this need a jmh

RFR: 8284697: Avoid parsing the doc comment of an element that is not documented

2022-04-15 Thread Pavel Rappo
We shouldn't parse comments that are going to be thrown away. Although the change is simple, I have no idea on how to test it. So I'm tempted to affix the "noreg-other" or "noreg-hard" label on the JBS issue. - Commit messages: - Reorder checks Changes:

Re: RFR: 8284908: Refine diagnostic positions for DCErroneous

2022-04-15 Thread Pavel Rappo
On Fri, 15 Apr 2022 16:58:55 GMT, Pavel Rappo wrote: > Before: > > Standard Doclet version 18+36-2087 > Building tree for all the packages and classes... > Generating /tmp/whatever/ExampleDiagnostics.html... > ExampleDiagnostics.java:5: error: unexpected content > * {@docRoot a} >^

RFR: 8284908: Refine diagnostic positions for DCErroneous

2022-04-15 Thread Pavel Rappo
Before: Standard Doclet version 18+36-2087 Building tree for all the packages and classes... Generating /tmp/whatever/ExampleDiagnostics.html... ExampleDiagnostics.java:5: error: unexpected content * {@docRoot a} ^ ExampleDiagnostics.java:11: error: unexpected content *