> Please review the code and tests to add support for a new `@spec url title`
> tag to javadoc. Note, this does not include any changes to API doc comments
> to use the new tag in JDK API documentation; that will come later.
Jonathan Gibbons has updated the pull request incrementally with one
> Please review the code and tests to add support for a new `@spec url title`
> tag to javadoc. Note, this does not include any changes to API doc comments
> to use the new tag in JDK API documentation; that will come later.
Jonathan Gibbons has updated the pull request incrementally with one
On Tue, 24 May 2022 19:50:41 GMT, Jonathan Gibbons wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
>
On Tue, 24 May 2022 21:29:53 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into 6251738.spec-tag-2
>> - address
On Tue, 24 May 2022 19:50:41 GMT, Jonathan Gibbons wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
>
On Tue, 24 May 2022 16:55:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java
>
On Tue, 24 May 2022 16:39:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeScanner.java line
> 515:
>
On Tue, 3 May 2022 13:41:29 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into 6251738.spec-tag-2
>> - address
On Tue, 3 May 2022 22:14:35 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocFinder.java
>> line 277:
>>
>>> 275:
>>> 276: private static boolean isNonEmpty(List list) {
>>> 277: return list != null && !list.isEmpty();
>>
On Tue, 24 May 2022 16:18:55 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.compiler/share/classes/com/sun/source/doctree/DocTreeVisitor.java
> line 302:
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
This pull request has now been integrated.
On Mon, 16 May 2022 23:16:25 GMT, Jonathan Gibbons wrote:
>> Please review a small fix to address use of snippets in source code in the
>> unnamed package.
>>
>> The core of the fix is to replace `packageName(pkg, utils)` (which returns
>> `""` for the unnamed package) with plain old
>>
> Please review the code and tests to add support for a new `@spec url title`
> tag to javadoc. Note, this does not include any changes to API doc comments
> to use the new tag in JDK API documentation; that will come later.
Jonathan Gibbons has updated the pull request with a new target base
On Mon, 16 May 2022 22:54:55 GMT, Jonathan Gibbons wrote:
>> Going forward, how about an `Args` builder, with fluent methods
>> `add(String)`, `addAll(String...)`, `addAll(List)` and
>> `add(Optional)` ... although that last one will cause warnings from
>> javac which grumbles about using
On Tue, 17 May 2022 23:14:48 GMT, Jonathan Gibbons wrote:
>> This PR is for an update to the doc comment `{@value}` tag to permit an
>> optional [format
>> string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax)
>> after the name of the tag.
>>
On Thu, 19 May 2022 22:05:50 GMT, Jonathan Gibbons wrote:
> Please review a test-only fix to make a recent new test more robust.
>
> The test was not fundamentally broken, so the essential functionality remains
> the same. However, it does assume access to the `src/jdk.javadoc` directory,
>
On Wed, 18 May 2022 18:43:44 GMT, Jonathan Gibbons wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
>
On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote:
>> Replaces usages of articles that follow each other in all combinations:
>> a/the, an?/an?, the/the…
>>
>> It's the last issue in the series, and it still touches different areas of
>> the code.
>
> Alexey Ivanov has updated the pull
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since the last
19 matches
Mail list logo
