On Mon, 28 Mar 2022 07:00:18 GMT, Ioi Lam wrote:
> If a test expects an English output, then it should explicitly say so when
> spawning a new JVM.
The problem there is knowing when that is the case. For
test/hotspot/jtreg/runtime/classFileParserBug/TestEmptyBootstrapMethodsAttr.java
the mess
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote:
> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en
> -Duser.country=US"`, some tests still fail because of default locale, Most of
> them are langtools tests.
>
> On MacOS 12.1.
I think fixing this in the test library is p
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote:
> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en
> -Duser.country=US"`, some tests still fail because of default locale, Most of
> them are langtools tests.
>
> On MacOS 12.1.
I have filed:
https://bugs.openjdk.java.net
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote:
> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en
> -Duser.country=US"`, some tests still fail because of default locale, Most of
> them are langtools tests.
>
> On MacOS 12.1.
It is not clear to me why only the listed te
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Fri, 10 Dec 2021 04:52:51 GMT, Jonathan Gibbons wrote:
> Please review a fix to update this test to match the latest man page
Ah - so the previously missing options are now documented.
Looks good.
Thanks for the quick fix.
David
-
Marked as reviewed by dholmes (Reviewer).
PR
On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons wrote:
>> Please review this semi-automatic update for the nroff man pages for JDK 18.
>> The changes update the version number, copyright year, and incorporate the
>> changes from the latest upstream files.
>
> We will also want to regenerate
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote:
> Please review this semi-automatic update for the nroff man pages for JDK 18.
> The changes update the version number, copyright year, and incorporate the
> changes from the latest upstream files.
Hi Jon,
This all looks good - I'm fa
On Mon, 7 Jun 2021 10:15:06 GMT, David Holmes wrote:
> Please review this trivial fix to a copyright line.
>
> Thanks,
> David
This pull request has now been integrated.
Changeset: 8130be56
Author:David Holmes
URL:
https://git.openjdk.java.ne
Please review this trivial fix to a copyright line.
Thanks,
David
-
Commit messages:
- 8268318: Missing comma in copyright header
Changes: https://git.openjdk.java.net/jdk/pull/4385/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4385&range=00
Issue: https://bugs.ope
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Mon, 1 Feb 2021 11:09:25 GMT, Magnus Ihse Bursie wrote:
> Before RC phase we need to ensure we have the final set of manpage updates
> published in OpenJDK.
Thanks for doing this Magnus! I had overlooked the fact we would need to re-run
this in 2021 regardless of whether there were any cont
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote:
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
The code in java.base was updated to use String::isEmpty in JDK 12
(JDK-8215281). There was follow-up in JDK 13 to do
the same in the java.desktop module (JDK-8223237). Changing the
On Thu, 10 Sep 2020 12:18:51 GMT, Kevin Rushforth wrote:
>> This should be broken up to deal with the files in different functional
>> areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas
>> need to be reviewed by differe
On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman wrote:
>> @kevinrushforth thanks. Done.
>>
>> Similar issues:
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=822
16 matches
Mail list logo
