Re: RFR: [15] JDK-8237492 Reorganize impl of doclet options

> On 21 Jan 2020, at 18:55, Jonathan Gibbons > wrote: > > Pavel, > > All great feedback, and all points addressed, as described in the details > inline below. > > New webrev, addresses all your comments, adds a couple of class-level doc > comments > to the two new classes, and fixes a

RFR [15] 8233795: Consider adding a notion of a Value-based class to API Documentation index

Hello, Please review the following (documentation) change for https://bugs.openjdk.java.net/browse/JDK-8233795: http://cr.openjdk.java.net/~prappo/8233795/webrev.00/ The detailed explanation can be found in the description in the JBS issue. Thanks, -Pavel

Re: RFR CSR: JDK-8237391 Add -Werror option to javadoc

Hi Jon, > On 17 Jan 2020, at 18:25, Jonathan Gibbons > wrote: > > Hi Pavel, > > Good feedback. > > The javadoc wording was deliberately more vague, because I couldn't think of > anything accurate and more specific to say. Essentially, we just want to > convey/enable one bit of info ...

Re: RFR CSR: JDK-8237391 Add -Werror option to javadoc

I like it. When comparing the wording for the corresponding option for javac I noticed that it is more vague than that of the proposed for javadoc: -Werror Terminate compilation if warnings occur (javac) -Werror: treat warnings as if they were errors (proposed for javadoc) Does the

RFR [15] 8236700: Upgrading JSZip from v3.1.5 to v3.2.2

Hello, Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8236700: http://cr.openjdk.java.net/~prappo/8236700/webrev.00/ This change upgrades the JSZip JavaScript library, used in Javadoc Search [1], to v3.22. I tested this change as follows. 1. Commented out

Re: RFR: JDK-8223536 jdk/javadoc/doclet/MetaTag/MetaTag.java still fails when run across midnight

Three dates are created in succession: (1) `startDate` on MetaTag:103, (2) `startTime` on HtmlConfiguration:265, and `date` on MetaTag:95. If dates (1) and (3) are equal, we then conclude that (2) must be the same as (1) and (3). If I read the intent correctly, this implication warrants the

Re: RFR: [15] JDK-8236048: Cleanup use of Utils.normalizeNewlines

Jon, Could you please explain why "generated files should only contain \n"? Is it possible to perform the `rawHtml.indexOf('\r') == -1` optimization check first thing in normalizeNewlines? New mechanics of string normalization is more readable, albeit is probably slower in a typical case. Old

RFR [14] 8236077: Clean up the use of modifiers and semicolons

Hello, Please review the following trivial change for https://bugs.openjdk.java.net/browse/JDK-8236077: http://cr.openjdk.java.net/~prappo/8236077/webrev.00/ This is a cleanup task. The above change removes the redundant modifiers (e.g. "public abstract" for interface methods). This

Re: RFR: [15] JDK-8235947: Cleanup/simplify Utils.getBlockTags

Jon, > On 16 Dec 2019, at 19:56, Jonathan Gibbons > wrote: > > On 12/16/19 11:45 AM, Pavel Rappo wrote: >> Jon, >> >>> On 16 Dec 2019, at 19:00, Jonathan Gibbons >>> wrote: >>> >>> On 12/16/2019 10:44 AM, Pavel Rappo wrote: >

Re: RFR: [15] JDK-8235947: Cleanup/simplify Utils.getBlockTags

Jon, > On 16 Dec 2019, at 19:00, Jonathan Gibbons > wrote: > > On 12/16/2019 10:44 AM, Pavel Rappo wrote: >> Jon, >> >> The idea of the fix looks reasonable. Since I'm new to javadoc, I have more >> questions than would >> probably be expected du

RFR [14] 8235447: Remove (obsolete) @author info from javadoc tests

Hello, Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8235447: http://cr.openjdk.java.net/~prappo/8235447/webrev.00/ This is a cleanup task. The above change removes @author (and the associated @since) tags from javadoc *tests* where those tags are not

Re: RFR [14] 8215038: Add a page that lists all system properties

e for the "Referenced In" column. It fit better with the > package and class references. > > And yes, any index is better than none. > > Thanks, Roger > > > On 12/11/19 12:26 PM, Pavel Rappo wrote: >> Hello, >> >> Please review the

RFR [14] 8215038: Add a page that lists all system properties

Hello, Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8215038: http://cr.openjdk.java.net/~prappo/8215038/webrev.00/ This change proposes a summary page for system properties. The change is largely based on prior work of Priya Lakshmi Muthuswamy

Re: RFR: 8233866: Text in table cells has inconsistent alignment

Hannes, Looks good. > On 10 Dec 2019, at 16:12, Hannes Wallnöfer > wrote: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8233866 > Webrev: http://cr.openjdk.java.net/~hannesw/8233866/webrev.00/ > API docs: http://cr.openjdk.java.net/~hannesw/8233866/api.00/ > > This is

Re: RFR: 8235670: Javadoc pages not printing correctly in some browsers

Hannes, Thanks for doing this! Looks good. > On 10 Dec 2019, at 17:12, Hannes Wallnöfer > wrote: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8235670 > Webrev: http://cr.openjdk.java.net/~hannesw/8235670/webrev.00/ > API docs:

Re: RFR [14] 8234746: Improve indexing of system properties

Hey Jon, thanks for looking at it. I have updated the webrev. This new webrev addresses Hannes' and yours comments: http://cr.openjdk.java.net/~prappo/8234746/webrev.01/ -Pavel > On 27 Nov 2019, at 21:20, Jonathan Gibbons > wrote: > > > > > On 11/25/2019 09:19

Re: RFR [14] 8234746: Improve indexing of system properties

gletWriterImpl.java: > > line 429: DocPaths docPaths = configuration.docPaths; > line 433: TypeElement te = utils.getEnclosingTypeElement(e); > > Would be nice to clean those up while you’re at it. Done. > Hannes > > >> Am 25.11.2019 um 18:19 schrieb Pavel Rap

RFR [14] 8235435: Remove (obsolete) @author info from javadoc source and tests

Hello, Please review the following change for https://bugs.openjdk.java.net/browse/JDK-8235435: http://cr.openjdk.java.net/~prappo/8235435/webrev.00/author.patch This change removes occurrences of @author tags throughout the source files and tests in Javadoc. It cleanly removes all the

<    2   3   4   5   6   7