On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote:
> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en
> -Duser.country=US"`, some tests still fail because of default locale, Most of
> them are langtools tests.
>
> On MacOS 12.1.
Can you look into why these tests do not fai
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client mo
On Wed, 12 Jan 2022 08:40:08 GMT, Hannes Wallnöfer wrote:
> Please review a change in how documentation from `@param` tags is generated.
>
> The old code generates parameter documentation for each `@param` in the order
> in which the tags occur in the comment, then adds documentation from
> i
On Fri, 10 Sep 2021 17:39:44 GMT, Pavel Rappo wrote:
> 8273609: Fix trivial doc typos in the compiler area
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5471
Hi,
A very useful proposal.
A few comments, I expect these will be addressed as the development
proceeds.
* In the @snippet tag, can the "class=" indicate a module name in
addition to the class name?
* Does the "lang=" tag need to be a closed set; if it were open, it
would give more f
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class"
On Tue, 1 Dec 2020 17:09:25 GMT, Pavel Rappo wrote:
>> /**
>> * {@return the result} Optional additional text.
>> */
>> ```
>> The java source looks a bit odd/unusual because the "first sentence" does
>> not appear to end with a period.
>> Though it seems like a convenience to include the '
On Fri, 20 Nov 2020 17:15:22 GMT, Jonathan Gibbons wrote:
> This change extends the functionality of the `@return` tag so that it can
> also be used as an inline tag in the first sentence of a description.
>
> The goal is to be able to simplify the following common pattern:
>
> /**
>
On 5/13/20 2:41 PM, Pavel Rappo wrote:
Thanks for chiming in, Roger.
On 13 May 2020, at 18:30, Roger Riggs wrote:
Hi,
The first sentence is not just any old sentence.
It has a very specific role to play in the javadoc both to introduce the class,
method, feild, etc.
AND to stand independent
Hi,
The first sentence is not just any old sentence.
It has a very specific role to play in the javadoc both to introduce the
class, method, feild, etc.
AND to stand independently when used in a summary.
That places a responsibility on the author to craft the sentence for
those purposes.
The
ot;sun.rmi.rmic.RMIGenerator", "sun.rmi.rmic.Main"},
./test/hotspot/jtreg/runtime/cds/appcds/test-classes/JimageClassPackage.java
"sun/rmi/rmic/Main",
./test/hotspot/jtreg/runtime/cds/appcds/SharedPackages.java
Thanks,
Amy
On 4/3/20 11:43 PM, Roger Riggs wrote:
Please
opefully, we'll figure out how to convey the fact that
there are missing s to the user real soon.
-Pavel
On 6 Mar 2020, at 19:10, Roger Riggs wrote:
Hi Pavel,
The System Properties page looks better with the links qualified by class or
package, or
the html document title. Developers will
Hi Pavel,
The System Properties page looks better with the links qualified by
class or package, or
the html document title. Developers will want to have a on their
document
so the properties listing is most informative.
Thanks, Roger
On 3/6/20 7:51 AM, Pavel Rappo wrote:
Hello,
Please rev
A bold suggestion is to switch to using java.time and move on from the
legacy java.Date.
On 1/14/20 7:23 PM, Jonathan Gibbons wrote:
Please review a fix for a problem that occurs when a test is run
across midnight.
Although it is difficult to confirm the root cause, and equally
difficult to
Hi,
For the links to the .html files, it would look better if it extracted
the xx
from the page to use for the "Referenced In" column. It fit better with
the package and class references.
And yes, any index is better than none.
Thanks, Roger
On 12/11/19 12:26 PM, Pavel Rappo wrote:
Hello
Thank you.
On 1/31/2013 11:34 AM, Jonathan Gibbons wrote:
On 01/31/2013 07:54 AM, Roger Riggs
wrote:
(Retry, first try may have gotten stuck in the non-subscriber
filter)
Please review
Please review this fix:
JDK-8004353: Generated html is wrong for overview.html; content has
incorrect css footer class
The webrev includes a description of the problem and solution plus a test.
http://cr.openjdk.java.net/~rriggs/webrev-t8004353/
Thanks, Roger
(Retry, first try may have gotten stuck in the non-subscriber filter)
Please review this fix:
JDK-8004353: Generated html is wrong for overview.html; content has
incorrect css footer class
The webrev includes a description of the problem and solution plus a test.
http://cr.openjdk.java.net/~r
22 matches
Mail list logo
