On Sat, 21 May 2022 00:09:30 GMT, liach wrote:
> Now the default values of annotation interface methods are rendered in
> `` tags like the values on the constant values page.
>
> Compare `BeanProperties` from [JDK
> 18](https://docs.oracle.com/en/java/javase/18/docs/api/ja
://cr.openjdk.java.net/~liach/8287118/java.desktop/java/beans/BeanProperty.html).
-
Commit messages:
- 8287118: Use monospace font for annotation default values
Changes: https://git.openjdk.java.net/jdk/pull/8822/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8822&range=00
On Thu, 5 May 2022 17:20:25 GMT, Jonathan Gibbons wrote:
>> Please review some cleanup updates to address issues reported by an IDE.
>>
>> The seeds for the change were a series of redundant casts, that have now all
>> been removed. Various other warnings and suggestions were made by the IDE
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote:
>> This is the second of two PRs to enhance JavaDoc search, it is based on the
>> first one (#8185).
>>
>> It adds a standalone search page (search.html) along with its own script
>> file (search-page.js). This PR is very similar to the
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote:
> This is the second of two PRs to enhance JavaDoc search, it is based on the
> first one (#8185).
>
> It adds a standalone search page (search.html) along with its own script file
> (search-page.js). This PR is very similar to the last
On Fri, 29 Oct 2021 13:09:31 GMT, Hannes Wallnöfer wrote:
> JDK-8275786: New javadoc option to add script files to generated documentation
looks like we no longer need to allow scripts in comments and add them
explicitly in class javadocs in order to use these custom scripts? fantastic it
seem
On Mon, 13 Sep 2021 17:56:14 GMT, Rémi Forax wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java line
> 215:
>
>> 213: pathLookup.remove(remove);
>> 214
On Wed, 28 Jul 2021 14:40:55 GMT, Pavel Rappo wrote:
>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which
>> hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge
>> of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets
>> bran
On Thu, 1 Jul 2021 13:50:25 GMT, Hannes Wallnöfer wrote:
> This change adds support for generating HTML links to the type arguments of
> enclosing classes when creating a link to an inner class. Previously, only a
> link to the inner class was created and the type arguments were even omitted
>
On Thu, 8 Jul 2021 20:40:04 GMT, Jonathan Gibbons wrote:
>> This change adds support for generating HTML links to the type arguments of
>> enclosing classes when creating a link to an inner class. Previously, only a
>> link to the inner class was created and the type arguments were even omitted
On Thu, 27 May 2021 03:20:34 GMT, Jonathan Gibbons wrote:
> Please review an update to `jdk.javadoc/jdk.javadoc.doclets.Reporter` to add
> 3 new methods and to improve the descriptions of other parts of the interface.
>
> The new methods provide access to the underlying streams (informally, for
On Thu, 20 May 2021 14:31:33 GMT, Hannes Wallnöfer wrote:
> This is a simple cleanup to replace the sentinel `HtmlTree.EMPTY` text
> constant with an instance that achieves the same by overriding `isValid()`. I
> think this is the nicer solution, and it allows us to remove the special case
> i
On Mon, 17 May 2021 16:51:54 GMT, liach
wrote:
> This change fixes when a method body has only inline tags that produce no
> output, the method summary will get eaten.
>
> This change allows `{@inheritDoc}` from empty parents to go through the code
> path used by `-nocommen
On Wed, 19 May 2021 17:04:12 GMT, Jonathan Gibbons wrote:
>> My general recollection is that this dates all the way back to the
>> introduction of `HtmlTree`. Prior to that, HTML was generated directly with
>> `PrintWriter.print` calls (!) and that code gave rise to some notable
>> errors; spe
On Wed, 19 May 2021 10:43:29 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>>
On Wed, 19 May 2021 12:08:27 GMT, Pavel Rappo wrote:
>> I was initially unsure about this, too. But take a look at
>> `HtmlTree.add(Content)` which handles `ContentBuilder` arguments in the
>> following way:
>>
>> if (content instanceof ContentBuilder) {
>> ((ContentBuilder
On Wed, 19 May 2021 10:02:47 GMT, Pavel Rappo wrote:
>> liach has refreshed the contents of this pull request, and previous commits
>> have been removed. The incremental views will show differences compared to
>> the previous content of the PR.
>
> src/jdk.javadoc/s
eg:test/langtools/jdk/javadoc/doclet` tests pass.
liach has updated the pull request incrementally with one additional commit
since the last revision:
Specify further what isValid expects and how it is used
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4066
On Tue, 18 May 2021 15:44:31 GMT, Pavel Rappo wrote:
>
>
> Meta: I would appreciate it if next time you could update your PR normally
> rather than forcefully. Pushing forcefully makes it harder to follow the
> progression of a PR.
For this change, in fact, you can pretty much discard all pr
eg:test/langtools/jdk/javadoc/doclet` tests pass.
liach has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last rev
On Tue, 18 May 2021 13:52:25 GMT, Jonathan Gibbons wrote:
>> liach has refreshed the contents of this pull request, and previous commits
>> have been removed. The incremental views will show differences compared to
>> the previous content of the PR.
>
> As a matter
On Mon, 17 May 2021 17:39:19 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>>
On Mon, 17 May 2021 20:26:02 GMT, Pavel Rappo wrote:
> Right off the bat: I'd be interested to know why an empty content demands
> special treatment.
if an empty content stays empty, it's handled like htmltree.empty in a special
case (just like what happens to nocomment) and included in table
On Mon, 17 May 2021 17:12:50 GMT, Hannes Wallnöfer wrote:
>> liach has refreshed the contents of this pull request, and previous commits
>> have been removed. The incremental views will show differences compared to
>> the previous content of the PR. The pull request conta
eg:test/langtools/jdk/javadoc/doclet` tests pass.
liach has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last rev
This change fixes when a method body has only inline tags that produce no
output, the method summary will get eaten.
This change allows `{@inheritDoc}` from empty parents to go through the code
path used by `-nocomment` and properly generate tables.
All `jtreg:test/langtools/jdk/javadoc/doclet`
On Thu, 25 Feb 2021 00:02:51 GMT, Jonathan Gibbons wrote:
> Please review a simple change to exclude type annotations from primitive
> types in the id generated for a method signature.
>
> There's a latent secondary issue, not addressed here, that quotes (`"`) in an
> attribute value are not e
On Thu, 25 Feb 2021 05:18:22 GMT, liach
wrote:
>> Please review a simple change to exclude type annotations from primitive
>> types in the id generated for a method signature.
>>
>> There's a latent secondary issue, not addressed here, that quotes (`"`)
On Fri, 19 Feb 2021 18:51:44 GMT, Jonathan Gibbons wrote:
> This change addresses a bug that was observed while playing with small demo
> API: some files may be generated twice.
>
> The fix is to build a single set of the files to be generated.
>
> Note: this bug also affected the generation o
On Fri, 29 Jan 2021 17:31:20 GMT, Jan Lahoda wrote:
> [This is a GitHub copy of:
> https://mail.openjdk.java.net/pipermail/compiler-dev/2020-March/014389.html ]
>
> Currently, (com.sun.tools.javac.code.)Symbol/s have a long field
> "flags_field", which holds various one-bit information ("Flags
On Fri, 8 Jan 2021 04:56:47 GMT, liach
wrote:
> Fixes the bug where receiver type is omitted in generated Javadoc when the
> immediate receiver type is not annotated (but some other type within is).
>
> In addition, fixed the bug where receiver type for constructor is not
)` is now qualified as `Bee.this`
> (without a link on `Bee`)
>
> (Note: receiver parameters are never included in the method summary section;
> they only present in method details sections)
>
> Non goal:
> - Won't fix the bug that a nested type's parent's ty
On Thu, 14 Jan 2021 12:32:42 GMT, Hannes Wallnöfer wrote:
>> liach has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase.
>
> src/jdk.javadoc/share/clas
On Tue, 12 Jan 2021 12:34:44 GMT, Hannes Wallnöfer wrote:
>> liach has updated the pull request with a new target base due to a merge or
>> a rebase.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
> line 331:
>
>> 329:
)` is now qualified as `Bee.this`
> (without a link on `Bee`)
>
> (Note: receiver parameters are never included in the method summary section;
> they only present in method details sections)
>
> Non goal:
> - Won't fix the bug that a nested type's parent's ty
On Tue, 12 Jan 2021 12:09:48 GMT, Hannes Wallnöfer wrote:
>> liach has updated the pull request with a new target base due to a merge or
>> a rebase. The pull request now contains one commit:
>>
>> 8259216: javadoc omits method receiver for any nested type annota
On Fri, 8 Jan 2021 19:23:44 GMT, liach
wrote:
>> Hi,
>> Please send an e-mail to dalibor.to...@oracle.com so that I can mark your
>> account as verified.
>
> Done.
A quick summary:
1. Receivers now are included if any part of their type hierarchy is annotated,
su
)` is now qualified as `Bee.this`
> (without a link on `Bee`)
>
> (Note: receiver parameters are never included in the method summary section;
> they only present in method details sections)
>
> Non goal:
> - Won't fix the bug that a nested type's parent's ty
)` is now qualified as `Bee.this`
> (without a link on `Bee`)
>
> (Note: receiver parameters are never included in the method summary section;
> they only present in method details sections)
>
> Non goal:
> - Won't fix the bug that a nested type's parent's ty
On Fri, 8 Jan 2021 18:39:21 GMT, Dalibor Topic wrote:
>> Fixes the bug where receiver type is omitted in generated Javadoc when the
>> immediate receiver type is not annotated (but some other type within is).
>>
>> In addition, fixed the bug where receiver type for constructor is not
>> proper
Fixes the bug where receiver type is omitted in generated Javadoc when the
immediate receiver type is not annotated (but some other type within is).
In addition, fixed the bug where receiver type for constructor is not properly
qualified (without a clickable link), i.e. `OuterClass.this` vs `thi
41 matches
Mail list logo
