Re: RFR: JDK-8246712 doclint incorrectly reports some HTML elements as empty

2020-06-09 Thread Pavel Rappo
Jon, Having in mind my extremely limited experience with jdk.compiler, the code change looks okay. However, the test could be even better: it would be cleaner if the test were built around actual tags rather than tag trees. Otherwise, the proposed test is of "grey-box" kind as it uses the fact

RFR: JDK-8246712 doclint incorrectly reports some HTML elements as empty

2020-06-08 Thread Jonathan Gibbons
Please review a simple change to ensure that inline tags are taken into account when checking if an HTML element is empty. As well as testing all existing inline tags, the test also tries to avoid future instances of this problem, by testing all subtypes of InlineTagTree, and ensuring that eac