Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint [v2]

2022-06-03 Thread Jonathan Gibbons
On Thu, 2 Jun 2022 23:33:13 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace > > test/langtools/jdk/javadoc/doclet/testDoclintDocletMessages/TestDocLintDocletMessages.java >

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint [v2]

2022-06-03 Thread Jonathan Gibbons
> Please review a moderate change to enable (most) doclet warnings even if > doclint is enabled. > > Since the introduction of doclint, there was some (small) overlap between the > small set of warnings generated by the doclet and the new larger set of > diagnostics that could be generated by

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-03 Thread Jonathan Gibbons
On Fri, 3 Jun 2022 15:59:04 GMT, Pavel Rappo wrote: > > I did a visual inspection over the Checker class. > > > The test is set up to be a framework to accommodate new cases if any should > > arise. > > This is good. It would be even better if we had a mechanism to reduce risk of >

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-03 Thread Pavel Rappo
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote: > Please review a moderate change to enable (most) doclet warnings even if > doclint is enabled. > > Since the introduction of doclint, there was some (small) overlap between the > small set of warnings generated by the doclet and the

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-03 Thread Jonathan Gibbons
On Fri, 3 Jun 2022 07:48:15 GMT, Pavel Rappo wrote: > > Since the introduction of doclint, there was some (small) overlap between > > the small set ... and the new larger set ... But, the sets do not overlap > > Do or do they not overlap? :) Ooops. Wrong word. I was meaning that neither set

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-03 Thread Pavel Rappo
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote: > Please review a moderate change to enable (most) doclet warnings even if > doclint is enabled. > > Since the introduction of doclint, there was some (small) overlap between the > small set of warnings generated by the doclet and the

Re: RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-02 Thread Erik Joelsson
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote: > Please review a moderate change to enable (most) doclet warnings even if > doclint is enabled. > > Since the introduction of doclint, there was some (small) overlap between the > small set of warnings generated by the doclet and the

RFR: JDK-8252717: Integrate/merge legacy standard doclet diagnostics and doclint

2022-06-02 Thread Jonathan Gibbons
Please review a moderate change to enable (most) doclet warnings even if doclint is enabled. Since the introduction of doclint, there was some (small) overlap between the small set of warnings generated by the doclet and the new larger set of diagnostics that could be generated by doclint.