Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v4]

2021-01-13 Thread Jonathan Gibbons
> Please review this change to centralize the management of HTML ids used by > the standard doclet in a single new factory class, `HtmlIds`, which utilizes > a new type-safe wrapper class around `String` called `HtmlId`. > > The new classes are used both when declaring ids (e.g. `HtmlTree.setId`

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

2021-01-13 Thread Jonathan Gibbons
On Wed, 13 Jan 2021 15:03:17 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> tidy up merge > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlId.java >

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

2021-01-13 Thread Jonathan Gibbons
On Wed, 13 Jan 2021 10:53:30 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> tidy up merge > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java >

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

2021-01-13 Thread Hannes Wallnöfer
On Mon, 11 Jan 2021 23:55:16 GMT, Jonathan Gibbons wrote: >> Please review this change to centralize the management of HTML ids used by >> the standard doclet in a single new factory class, `HtmlIds`, which utilizes >> a new type-safe wrapper class around `String` called `HtmlId`. >> >> The ne

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

2021-01-11 Thread Jonathan Gibbons
> Please review this change to centralize the management of HTML ids used by > the standard doclet in a single new factory class, `HtmlIds`, which utilizes > a new type-safe wrapper class around `String` called `HtmlId`. > > The new classes are used both when declaring ids (e.g. `HtmlTree.setId`

Re: RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v2]

2021-01-11 Thread Jonathan Gibbons
> Please review this change to centralize the management of HTML ids used by > the standard doclet in a single new factory class, `HtmlIds`, which utilizes > a new type-safe wrapper class around `String` called `HtmlId`. > > The new classes are used both when declaring ids (e.g. `HtmlTree.setId`

RFR: JDK-8259283: use new HtmlId and HtmlIds classes

2021-01-05 Thread Jonathan Gibbons
Please review this change to centralize the management of HTML ids used by the standard doclet in a single new factory class, `HtmlIds`, which utilizes a new type-safe wrapper class around `String` called `HtmlId`. The new classes are used both when declaring ids (e.g. `HtmlTree.setId`) and whe