Re: RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-24 Thread Hannes Wallnöfer
On Thu, 12 Aug 2021 17:38:14 GMT, Jonathan Gibbons wrote: > Please review a medium-size update to the support for JavaFX properties in > the Standard Doclet. > > A JavaFX property is typically defined by a group of up to 4 elements: > * an optional field, which is typically private > * a no-arg

Re: RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-24 Thread Hannes Wallnöfer
On Mon, 23 Aug 2021 20:20:19 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/CommentUtils.java >> line 528: >> >>> 526: * @return a content tree for the text >>> 527: */ >>> 528: public List getComment(String key, Object o0, >>>

Re: RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-23 Thread Jonathan Gibbons
On Wed, 18 Aug 2021 12:00:15 GMT, Hannes Wallnöfer wrote: > What is the purpose of this rather complex method to format a text resource? > It seems like it is arguments `o1` and `o2` are never used. Couldn't this be > implemented simply using `MessageFormat` as it used to be? This is the `DocT

Re: RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-18 Thread Hannes Wallnöfer
On Thu, 12 Aug 2021 17:38:14 GMT, Jonathan Gibbons wrote: > Please review a medium-size update to the support for JavaFX properties in > the Standard Doclet. > > A JavaFX property is typically defined by a group of up to 4 elements: > * an optional field, which is typically private > * a no-arg

Re: RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-13 Thread Kevin Rushforth
On Thu, 12 Aug 2021 17:38:14 GMT, Jonathan Gibbons wrote: > Please review a medium-size update to the support for JavaFX properties in > the Standard Doclet. > > A JavaFX property is typically defined by a group of up to 4 elements: > * an optional field, which is typically private > * a no-arg

RFR: JDK-8270195: Add missing links between methods of JavaFX properties

2021-08-12 Thread Jonathan Gibbons
Please review a medium-size update to the support for JavaFX properties in the Standard Doclet. A JavaFX property is typically defined by a group of up to 4 elements: * an optional field, which is typically private * a no-args property method, whose name ends in `Property` and which returns an a