On Wed, 25 May 2022 17:00:16 GMT, Jonathan Gibbons wrote:
>> Please review a small fix to address use of snippets in source code in the
>> unnamed package.
>>
>> The core of the fix is to replace `packageName(pkg, utils)` (which returns
>> `""` for the unnamed package) with plain old
>>
> Please review a small fix to address use of snippets in source code in the
> unnamed package.
>
> The core of the fix is to replace `packageName(pkg, utils)` (which returns
> `""` for the unnamed package) with plain old
> `pkg.getQualifiedName().toString()` (which returns an empty string for
On Tue, 24 May 2022 19:46:51 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
>
On Mon, 16 May 2022 23:16:25 GMT, Jonathan Gibbons wrote:
>> Please review a small fix to address use of snippets in source code in the
>> unnamed package.
>>
>> The core of the fix is to replace `packageName(pkg, utils)` (which returns
>> `""` for the unnamed package) with plain old
>>
On Mon, 16 May 2022 22:54:55 GMT, Jonathan Gibbons wrote:
>> Going forward, how about an `Args` builder, with fluent methods
>> `add(String)`, `addAll(String...)`, `addAll(List)` and
>> `add(Optional)` ... although that last one will cause warnings from
>> javac which grumbles about using
> Please review a small fix to address use of snippets in source code in the
> unnamed package.
>
> The core of the fix is to replace `packageName(pkg, utils)` (which returns
> `""` for the unnamed package) with plain old
> `pkg.getQualifiedName().toString()` (which returns an empty string for
On Mon, 16 May 2022 22:49:09 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetUnnamedPackage.java
>> line 82:
>>
>>> 80:
>>> 81: javadoc(args.toArray(String[]::new));
>>> 82: checkExit(useSourcePath ? Exit.OK : Exit.ERROR);
>>
>>
On Mon, 16 May 2022 10:31:25 GMT, Pavel Rappo wrote:
>> Please review a small fix to address use of snippets in source code in the
>> unnamed package.
>>
>> The core of the fix is to replace `packageName(pkg, utils)` (which returns
>> `""` for the unnamed package) with plain old
>>
On Mon, 16 May 2022 09:29:19 GMT, Hannes Wallnöfer wrote:
>> Please review a small fix to address use of snippets in source code in the
>> unnamed package.
>>
>> The core of the fix is to replace `packageName(pkg, utils)` (which returns
>> `""` for the unnamed package) with plain old
>>
On Fri, 13 May 2022 21:51:32 GMT, Jonathan Gibbons wrote:
> Please review a small fix to address use of snippets in source code in the
> unnamed package.
>
> The core of the fix is to replace `packageName(pkg, utils)` (which returns
> `""` for the unnamed package) with plain old
>
On Fri, 13 May 2022 21:51:32 GMT, Jonathan Gibbons wrote:
> Please review a small fix to address use of snippets in source code in the
> unnamed package.
>
> The core of the fix is to replace `packageName(pkg, utils)` (which returns
> `""` for the unnamed package) with plain old
>
Please review a small fix to address use of snippets in source code in the
unnamed package.
The core of the fix is to replace `packageName(pkg, utils)` (which returns
`""` for the unnamed package) with plain old
`pkg.getQualifiedName().toString()` (which returns an empty string for the
12 matches
Mail list logo
