Re: RFR: JDK-8286101: Support formatting in @value tag [v3]

2022-05-24 Thread Pavel Rappo
On Tue, 17 May 2022 23:14:48 GMT, Jonathan Gibbons wrote: >> This PR is for an update to the doc comment `{@value}` tag to permit an >> optional [format >> string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) >> after the name of the tag. >>

Re: RFR: JDK-8286101: Support formatting in @value tag [v3]

2022-05-17 Thread Jonathan Gibbons
> This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > > {@value optional-format-string optional-reference} > > If

Re: RFR: JDK-8286101: Support formatting in @value tag [v2]

2022-05-17 Thread Jonathan Gibbons
On Mon, 16 May 2022 09:57:14 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/jdk.compiler/share/classes/com/sun/source/doctree/ValueTree.java line 55: > >> 53:

Re: RFR: JDK-8286101: Support formatting in @value tag [v2]

2022-05-17 Thread Jonathan Gibbons
> This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > > {@value optional-format-string optional-reference} > > If

Re: RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Jonathan Gibbons
On Mon, 16 May 2022 10:07:18 GMT, Pavel Rappo wrote: > So far the idea looks okay. My feedback is purely on its implementation. > > I'm concerned about backward compatibility. If we believe that it is unlikely > that javadoc can be configured to use a custom implentation of >

Re: RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Pavel Rappo
On Thu, 5 May 2022 23:39:46 GMT, Jonathan Gibbons wrote: > This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > >

RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Jonathan Gibbons
This PR is for an update to the doc comment `{@value}` tag to permit an optional [format string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) after the name of the tag. {@value optional-format-string optional-reference} If given, the format