Re: RFR: JDK-8286153: Remove redundant casts and other cleanup [v3]

2022-05-05 Thread Jonathan Gibbons
> Please review some cleanup updates to address issues reported by an IDE. > > The seeds for the change were a series of redundant casts, that have now all > been removed. Various other warnings and suggestions were made by the IDE > for the affected files. There were a number of places with

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup [v2]

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 23:51:59 GMT, liach wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassUseMapper.java >

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup [v2]

2022-05-05 Thread liach
On Thu, 5 May 2022 17:20:25 GMT, Jonathan Gibbons wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup [v2]

2022-05-05 Thread Pavel Rappo
On Thu, 5 May 2022 17:20:25 GMT, Jonathan Gibbons wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup [v2]

2022-05-05 Thread Jonathan Gibbons
> Please review some cleanup updates to address issues reported by an IDE. > > The seeds for the change were a series of redundant casts, that have now all > been removed. Various other warnings and suggestions were made by the IDE > for the affected files. There were a number of places with

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 14:43:52 GMT, Jonathan Gibbons wrote: >> Correction: `switch` _expressions_ in this case. > > will examine; I was (generally) trying not to override IDE formatting. fixed - PR: https://git.openjdk.java.net/jdk/pull/8543

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 14:43:37 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java >> line 1063: >> >>> 1061: if (enclosing != null) { >>> 1062: return switch (enclosing.getKind()) { >>> 1063:

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 10:09:32 GMT, Pavel Rappo wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE >>

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 10:38:43 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java >> line 1206: >> >>> 1204: AccessKind accessValue = null; >>> 1205: for (ElementKind kind : ALLOWED_KINDS) { >>> 1206:

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 10:17:16 GMT, Pavel Rappo wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE >>

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Jonathan Gibbons
On Thu, 5 May 2022 09:58:13 GMT, Pavel Rappo wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE >>

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Pavel Rappo
On Thu, 5 May 2022 10:30:17 GMT, Pavel Rappo wrote: >> Please review some cleanup updates to address issues reported by an IDE. >> >> The seeds for the change were a series of redundant casts, that have now all >> been removed. Various other warnings and suggestions were made by the IDE >>

Re: RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-05 Thread Pavel Rappo
On Thu, 5 May 2022 00:18:56 GMT, Jonathan Gibbons wrote: > Please review some cleanup updates to address issues reported by an IDE. > > The seeds for the change were a series of redundant casts, that have now all > been removed. Various other warnings and suggestions were made by the IDE >

RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-04 Thread Jonathan Gibbons
Please review some cleanup updates to address issues reported by an IDE. The seeds for the change were a series of redundant casts, that have now all been removed. Various other warnings and suggestions were made by the IDE for the affected files. There were a number of places with redundant