Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jonathan Gibbons
Thanks. -- Jon On 01/08/2018 03:02 PM, Jason Tedor wrote: Sure: $ git clone https://github.com/elastic/elasticsearch.git $ cd elasticsearch $ git checkout c831442352c00f6cf840ffc3cbae64694935ce8b $ JAVA_HOME=/path/to/jdk-10 gradle clean :cor

Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jason Tedor
Sure: $ git clone https://github.com/elastic/elasticsearch.git $ cd elasticsearch $ git checkout c831442352c00f6cf840ffc3cbae64694935ce8b $ JAVA_HOME=/path/to/jdk-10 gradle clean :core:javadoc this will fail and the build will say > Javadoc generation failed. Generated Javadoc options file (use

Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jonathan Gibbons
That would help. Thanks. -- Jon On 01/08/2018 02:45 PM, Jason Tedor wrote: Jonathan: If it helps, I can show you how to use Gradle to produce the arguments that are passed to the javadoc command line, and then you'll have a pure javadoc command line that you can use to reproduce the issue? O

Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jason Tedor
Jonathan: If it helps, I can show you how to use Gradle to produce the arguments that are passed to the javadoc command line, and then you'll have a pure javadoc command line that you can use to reproduce the issue? On Mon, Jan 8, 2018 at 4:31 PM Jonathan Gibbons wrote: > I spent hour on Friday

Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jonathan Gibbons
I spent hour on Friday trying to create a small test case, but without success so far. It seems notable that the example you list in your source code is a lambda whose body contains 3 levels of nested anon classes. In general, I strongly dislike having to debug javac code involving large exter

Re: Javadoc tool not handling nested anonymous classes

2018-01-08 Thread Jason Tedor
Thanks Jonathan. To clarify, is that something that you will do or are you expecting me to take action here? On Fri, Jan 5, 2018 at 4:35 PM Jonathan Gibbons wrote: > Jason, > > Thanks for the experiments and report. It sounds like we can make a very > reduced test case from that. > > -- Jon > >

Re: Javadoc tool not handling nested anonymous classes

2018-01-05 Thread Jason Tedor
Thanks again for your replies Jonathan, this is helpful. > I see that one possibility may be the presence of source code on the source or class path, and equivalent previously-compiled classes on the class path. This is indeed the case, the compiled classes are on the -classpath passed to the inv

Re: Javadoc tool not handling nested anonymous classes

2018-01-05 Thread Jonathan Gibbons
Jason, Thanks for the experiments and report. It sounds like we can make a very reduced test case from that. -- Jon On 01/05/2018 01:30 PM, Jason Tedor wrote: Thanks again for your replies Jonathan, this is helpful. > I see that one possibility may be the presence of source code on the so

Re: Javadoc tool not handling nested anonymous classes

2018-01-04 Thread Jonathan Gibbons
On 01/04/2018 04:37 PM, Jonathan Gibbons wrote: One other change may be relevant: JDK-8177588, in which we made javadoc be more strict when it encounters compilation errors. This was fix in JDK 10 b10. We can probably take this off the table, as the fix originally appeared in JDK 9. -

Re: Javadoc tool not handling nested anonymous classes

2018-01-04 Thread Jonathan Gibbons
Just because it worked before, and repeatedly works on a clean build, does not make the environment setup inherently correct ;-) Reading a lot of the background material, including other similar bugs, I see that one possibility may be the presence of source code on the source or class path, an

Re: Javadoc tool not handling nested anonymous classes

2018-01-04 Thread Jason Tedor
Thanks for the reply Jonathan, I appreciate it. I did read the entire error message and I'm sorry to have to disagree with your assessment (I am not saying you're wrong, only that with the information I have I disagree with you). These are on clean builds in our CI environment, and this reproduces

Re: Javadoc tool not handling nested anonymous classes

2018-01-04 Thread Jonathan Gibbons
On 12/21/2017 02:07 PM, Jason Tedor wrote: We are seeing this error on JDK 10-ea+35 and JDK 10-ea+36 on all environments (have not tested earlier builds): javadoc: error - An internal exception has occurred. (com.sun.tools.javac.code.ClassFinder$BadClassFile: bad class file: /home/j