On Thu, 8 Oct 2020 09:15:37 GMT, Hannes Wallnöfer wrote:
>> Comment?
>
> I haven't delved into the pros and cons of different CSS measurement units,
> but I can do that. For this change, the
> purpose was to leave spacings unchanged, so experimenting with different
> units was not something I w
On Thu, 8 Oct 2020 09:41:05 GMT, Hannes Wallnöfer wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Thu, 8 Oct 2020 09:36:04 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js
>> line 89:
>>
>>> 87: selected.previousSibling.focus();
>>> 88: e.preventDefault();
>>> 89: } else if ((e.keyCode =
On Tue, 6 Oct 2020 23:31:48 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused st
> This changes the output of the `html.markup.Table` class to plain `div`
> elements, using CSS Grid Layout to display them
> in a tabular format.
> I decided against renaming the Table class and related identifiers even
> though it does no longer emit an HTML
> element. I admit this results in
On Tue, 6 Oct 2020 23:45:27 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused st
On Tue, 6 Oct 2020 23:33:45 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
>> line 440:
>>
>>> 438: .summary-table > div {
>>> 439: text-align:left;
>>> 440: padding: 8px 3px 3px 7px;
>>
>> General comment: sh
On Tue, 6 Oct 2020 23:30:22 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused st
> This changes the output of the `html.markup.Table` class to plain `div`
> elements, using CSS Grid Layout to display them
> in a tabular format.
> I decided against renaming the Table class and related identifiers even
> though it does no longer emit an HTML
> element. I admit this results in
On Fri, 25 Sep 2020 17:50:39 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused s
On Mon, 5 Oct 2020 13:51:01 GMT, Hannes Wallnöfer wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Mon, 5 Oct 2020 14:27:52 GMT, Hannes Wallnöfer wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Mon, 28 Sep 2020 17:46:31 GMT, Hannes Wallnöfer wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java
>> line 147:
>>
>>> 145: methodSubWriter = new MethodWriterImpl(this);
>>> 146: constrSubWriter = new ConstructorWriterImpl(th
> This changes the output of the `html.markup.Table` class to plain `div`
> elements, using CSS Grid Layout to display them
> in a tabular format.
> I decided against renaming the Table class and related identifiers even
> though it does no longer emit an HTML
> element. I admit this results in
> This changes the output of the `html.markup.Table` class to plain `div`
> elements, using CSS Grid Layout to display them
> in a tabular format.
> I decided against renaming the Table class and related identifiers even
> though it does no longer emit an HTML
> element. I admit this results in
On Fri, 25 Sep 2020 16:51:00 GMT, Jonathan Gibbons wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Fri, 25 Sep 2020 17:52:57 GMT, Jonathan Gibbons wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Fri, 25 Sep 2020 17:39:20 GMT, Jonathan Gibbons wrote:
>> This changes the output of the `html.markup.Table` class to plain `div`
>> elements, using CSS Grid Layout to display them
>> in a tabular format.
>> I decided against renaming the Table class and related identifiers even
>> though it
On Fri, 18 Sep 2020 14:51:29 GMT, Hannes Wallnöfer wrote:
> This changes the output of the `html.markup.Table` class to plain `div`
> elements, using CSS Grid Layout to display them
> in a tabular format.
> I decided against renaming the Table class and related identifiers even
> though it does
I like the overall description for the changes. (I've not yet started
reading the code changes.)
I agree with not changing the name of the Table class. Even before your
changes, the class had evolved to more than a simple HTML . It's
more useful that it represents the abstraction of some tabu
20 matches
Mail list logo
