Hi Kumar,
Thanks for spotting this. The cause is the equivalent strange indent in
the original source. The conversion program does not change the
preceding indent for the opening `"""`. The body of the text block then
follows the indent of the `"""`.
The main change has already been pushed,
Hi Jon,
I generally like this…:)
I noticed a strange indent at line #70
http://cr.openjdk.java.net/~jjg/8242532/webrev.01/test/langtools/jdk/javadoc/doclet/constantValues/TestConstantValuesDriver.java.frames.html
I did not check every file and diff it is too laborious.
Thanks
Kumar
On May 5
Thanks for the +1, but I will do one more pass to tweak the parameters
for very long lines and for short lines.
-- Jon
On 5/5/20 9:12 AM, Hannes Wallnoefer wrote:
Yes, I noted that text blocks are not that great with string concatenation.
I agree with all you say, as I said, these are all que
Yes, I noted that text blocks are not that great with string concatenation.
I agree with all you say, as I said, these are all questions of taste and it’s
easy to get lost in them. I also think you spent a good amount of time tweaking
the parameters already, and the result looks very good.
So
Hannes,
Thanks for the feedback.
It is easy enough to change the threshhold for wrapping very long
lines. I'll look at the other cases you mention, but the more we get
into style issues like "convert all or convert none", the harder it will
be to come up with rules for the converter. At some
Hi Jon,
I find that using text blocks increase readability greatly, and the patch looks
mostly very good to me.
There are a few cases where I am not quite sure about the criteria used to
decide whether or not to use text blocks. Nothing too bad but I think these are
worth discussing:
TestCons
