Re: RFR: JDK-8267574: Dead code in HtmlStyle/HtmlDocletWriter [v2]

2021-05-25 Thread Jonathan Gibbons
> Please review a simple `noreg-cleanup` change to remove some dead code. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four addition

Re: RFR: JDK-8267574: Dead code in HtmlStyle/HtmlDocletWriter [v2]

2021-05-25 Thread Jonathan Gibbons
On Tue, 25 May 2021 14:57:58 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css >> line 580: >> >>> 578: display:inline-block; >>> 579: } >>> 580: div.block div.deprecation-comment, div.block div.block >>> span.emphas

Re: RFR: JDK-8267574: Dead code in HtmlStyle/HtmlDocletWriter

2021-05-25 Thread Jonathan Gibbons
On Tue, 25 May 2021 08:36:13 GMT, Hannes Wallnöfer wrote: >> Please review a simple `noreg-cleanup` change to remove some dead code. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css > line 580: > >> 578: display:inline-block; >> 579: } >> 580:

Re: RFR: JDK-8267574: Dead code in HtmlStyle/HtmlDocletWriter

2021-05-25 Thread Hannes Wallnöfer
On Sat, 22 May 2021 16:18:00 GMT, Jonathan Gibbons wrote: > Please review a simple `noreg-cleanup` change to remove some dead code. Looks good, but I found another potential cleanup target close by (see inline comment). src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resourc