Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v3]

2022-05-04 Thread Pavel Rappo
On Tue, 3 May 2022 22:47:49 GMT, Jonathan Gibbons wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement t

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v3]

2022-05-03 Thread Jonathan Gibbons
> Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to eliminate the use of fall-through semantics. Jonathan Gibbons

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Jonathan Gibbons
On Tue, 3 May 2022 22:06:29 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line > 217: > >

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Pavel Rappo
On Tue, 3 May 2022 22:30:51 GMT, Jonathan Gibbons wrote: > Yes, but RECORD is handled in a different case, along with METHOD and > CONSTRUCTOR, because it can have "plain" `@param` as well as type-parameter > `@param`. In contrast, a class or interface can only have type-parameter > `@param` a

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Jonathan Gibbons
On Tue, 3 May 2022 22:16:25 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line > 866: > >

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Pavel Rappo
On Tue, 3 May 2022 21:53:21 GMT, Jonathan Gibbons wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement t

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Pavel Rappo
On Tue, 3 May 2022 21:53:21 GMT, Jonathan Gibbons wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement t

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

2022-05-03 Thread Jonathan Gibbons
> Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to eliminate the use of fall-through semantics. Jonathan Gibbons

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class

2022-05-03 Thread Jonathan Gibbons
On Tue, 3 May 2022 11:03:02 GMT, Pavel Rappo wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement to eli

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class

2022-05-03 Thread Jonathan Gibbons
On Tue, 3 May 2022 11:31:09 GMT, Pavel Rappo wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement to eli

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class

2022-05-03 Thread Pavel Rappo
On Fri, 29 Apr 2022 00:29:50 GMT, Jonathan Gibbons wrote: > Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to el

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class

2022-05-02 Thread Iris Clark
On Fri, 29 Apr 2022 00:29:50 GMT, Jonathan Gibbons wrote: > Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to el