Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Robert Scholte
I guess so :) thanks, Robert ps. can you add the label apache-maven-found to the issues so we can easily follow progress? On Mon, 20 Nov 2017 21:33:33 +0100, Jonathan Gibbons wrote: Does this mean we have a secondary bug, that the error message you got said "package" when it meant "mo

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Jonathan Gibbons
Does this mean we have a secondary bug, that the error message you got said "package" when it meant "module"? -- Jon On 11/20/17 12:01 PM, Robert Scholte wrote: javadoc: error - No source files for package com.io7m.bugs.c

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Jonathan Gibbons
That seems like a bug that needs to be fixed. As well as applications, there are also service-provider modules, which deserve to be documented, but which may not export API. -- Jon On 11/20/17 12:01 PM, Robert Scholte wrote: Hi Jon, I've found the problem.  The issue is that the module des

Re: The maven-javadoc-plugin on JDK 9

2017-11-20 Thread Robert Scholte
Hi Jon, I've found the problem. The issue is that the module descriptor of c doesn't export any packages. Considering c is an application, it makes sense because that code is not shared for third parties. But what if you are using javadoc as documentation of your code? Can this be solved *

Re: The maven-javadoc-plugin on JDK 9

2017-11-19 Thread Robert Scholte
Hi Jon, that's what I've tried to do, but when using Marks project as example it fails with: [parsing completed 0ms] [loading /modules/java.base/module-info.class] Loading source files for package com.io7m.bugs.c... javadoc: error - No source files for package com.io7m.bugs.c 1 error I'm kin

Re: The maven-javadoc-plugin on JDK 9

2017-11-19 Thread Mark Raynsford
'Ello. Thanks for the detailed response! On 2017-11-19T10:50:08 -0800 Jonathan Gibbons wrote: > > There is one other solution ... but it comes more in the "advanced" > category, but may be reasonable in the context of the Maven plugin. > You can use >     --patch-module /module-name/=/path/ >

Re: The maven-javadoc-plugin on JDK 9

2017-11-19 Thread Jonathan Gibbons
Robert, For javac and javadoc, --patch-module is also permitted for sources; it was a late change/addition towards the end of JDK 9. In the test case you are playing with, is com.io7m.bugs.c a package name as well as a module name?  If not, and if you think javadoc is misinterpreting the nam

Re: The maven-javadoc-plugin on JDK 9

2017-11-19 Thread Jonathan Gibbons
If you are wanting to generate javadoc for multiple modules, you have two possibilities ... From the command line ... Yes, you must use --module-source-path, but it allows a syntax for cases like this. It does require that the source for each module must be "under" a directory with the same n

The maven-javadoc-plugin on JDK 9

2017-11-19 Thread Mark Raynsford
Hello. We're in the process of trying to get the maven-javadoc-plugin to work correctly when generating documentation for modules. I have a simple test case here that fails: https://github.com/io7m/maven-javadoc-bug-20171118 See the README.txt for the full build log and error messages. I thin