Re: docencoding not available to stylesheet

2013-02-07 Thread jayashree viswanathan
Java 7 . Thanks and Regards, Jayashree Viswanathan Message: 1 Date: Wed, 03 Oct 2012 12:10:03 -0700 From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset

Re: docencoding not available to stylesheet

2012-11-22 Thread jayashree viswanathan
athan Message: 1 Date: Wed, 03 Oct 2012 12:10:03 -0700 From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Note that you open the w

Re: docencoding not available to stylesheet

2012-11-22 Thread jayashree viswanathan
From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Note that you open the writer twice, once unmodified on like 369, then again i

Re: docencoding not available to stylesheet

2012-10-11 Thread jayashree viswanathan
Jayashree Viswanathan Message: 1 Date: Wed, 03 Oct 2012 12:10:03 -0700 From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Note that you

Re: docencoding not available to stylesheet

2012-10-10 Thread Jonathan Gibbons
g not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Note that you open the writer twice, once unmodified on like 369, then again in the lines you added. I suggest you either chan

Re: docencoding not available to stylesheet

2012-10-10 Thread Jonathan Gibbons
Java 7 . Thanks and Regards, Jayashree Viswanathan Message: 1 Date: Wed, 03 Oct 2012 12:10:03 -0700 From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; charset

Re: docencoding not available to stylesheet

2012-10-08 Thread jayashree viswanathan
in Java 7 . Thanks and Regards, Jayashree Viswanathan Message: 1 Date: Wed, 03 Oct 2012 12:10:03 -0700 From: Jonathan Gibbons Subject: Re: docencoding not available to stylesheet To: jayashree viswanathan Cc: javadoc-dev Message-ID:<[email protected]> Content-Type: text/plain; chars

Re: docencoding not available to stylesheet

2012-10-03 Thread Jonathan Gibbons
Note that you open the writer twice, once unmodified on like 369, then again in the lines you added. I suggest you either change line 369 to an uninitialized declaration, or merge 369-374 into a declaration whose initialization involved a conditional expression. But, note that there may be big

Re: docencoding not available to stylesheet

2012-10-03 Thread jayashree viswanathan
Hi Jon , Got a chance to look at the webrev ? Thanks ! Regards, Jayashree V On 17-09-2012 8:57 PM, Jonathan Gibbons wrote: OK, I will take a look at your latest webrev. -- Jon On 09/16/2012 11:54 PM, jayashree viswanathan wrote: Hi Jon , Thanks a lot for looking in and passing your review

Re: docencoding not available to stylesheet

2012-09-17 Thread jayashree viswanathan
Hi Jon , Thanks a lot for looking in and passing your review comments . I have made the changes Please find the webrev at http://cr.openjdk.java.net/~luchsh/7006270_3/ Regards, Jayashree Viswanathan On 13-09-2012 10:55 PM, Jonathan Gibbons wrote: The basic fix looks OK, I'd recommend a coupl

Re: docencoding not available to stylesheet

2012-09-17 Thread Jonathan Gibbons
OK, I will take a look at your latest webrev. -- Jon On 09/16/2012 11:54 PM, jayashree viswanathan wrote: Hi Jon , Thanks a lot for looking in and passing your review comments . I have made the changes Please find the webrev at http://cr.openjdk.java.net/~luchsh/7006270_3/ Regards, Jayashr

Re: docencoding not available to stylesheet

2012-09-13 Thread Jonathan Gibbons
The basic fix looks OK, I'd recommend a couple of white-space tweaks, such as a space between ")" and "{" on line 370, and after "," on line 373. In the tests, I suggest blank lines before/after the IBM copyright on both files, and remove the space before the comment on line 23 in the Test.jav

Re: docencoding not available to stylesheet

2012-09-04 Thread jayashree viswanathan
Hi, Please let me know if any one is interested in having a look at this patch . Thanks and Regards, Jayashree V On 31-08-2012 3:20 PM, jayashree viswanathan wrote: *Problem statement : *Stylesheet.css is not getting encoded like the other generated html files while using -docencoding *Recre

docencoding not available to stylesheet

2012-08-31 Thread jayashree viswanathan
*Problem statement : *Stylesheet.css is not getting encoded like the other generated html files while using -docencoding *Recreation step : * javadoc -docencoding "use non-ascii encoding" HelloWorld.java say , jdk1.8.0\bin\javadoc.exe -docencoding Cp930 -d docencoding3 HelloWorld.java *Explanat