thanks to all the reviewers, the code for sealed classes has already
been pushed to mainline.
Vicente
On 5/18/20 6:42 PM, Vicente Romero wrote:
Hi,
Please review this patch for the compiler, javadoc and
javax.lang.model support for the JEP 360 Sealed Classes (Preview). The
changes are provi
Am 01.06.2020 um 16:55 schrieb Jonathan Gibbons :
>
> Unless I'm missing something, it still seems wrong to put the trimmedSig in
> the tree, instead of the sig. You already have the module name available as
> a separate parameter to the newReferenceTree call.
>
> I'm concerned that if you par
On 6/2/20 7:13 AM, Hannes Wallnoefer wrote:
That’s correct, the toString() representation and default link label will be
different from the actual string in the doc comment. The rationale is that the
trailing slash is there just to disambiguate the link as a module reference,
and the slash i
On 6/2/20 8:14 AM, Jonathan Gibbons wrote:
On 6/2/20 7:13 AM, Hannes Wallnoefer wrote:
That’s correct, the toString() representation and default link label
will be different from the actual string in the doc comment. The
rationale is that the trailing slash is there just to disambiguate
the
I have uploaded a new Webrev that preserves the trailing slash, and only
removes it when rendering the link.
http://cr.openjdk.java.net/~hannesw/8164408/webrev.01/
I also replaced the getReferencedClassName method in class CommentHelper with a
new getReferencedModuleName that makes use of the n
+1
On 6/2/20 9:34 AM, Hannes Wallnoefer wrote:
I have uploaded a new Webrev that preserves the trailing slash, and only
removes it when rendering the link.
http://cr.openjdk.java.net/~hannesw/8164408/webrev.01/
I also replaced the getReferencedClassName method in class CommentHelper with a
n
