Re: RFR: [test,16] JDK-8164597 : TestIOException.java fails after push for JDK-8164130.

2020-06-25 Thread Pavel Rappo
> On 24 Jun 2020, at 15:28, Jonathan Gibbons > wrote: > > Yes, it's an oversight that the ProblemList entry is commented out and not > deleted. I'll fix that. Thanks. > It is intended to be helpful to users to provide details in the exception > about the file causing the problem. The diffe

Re: RFR: [test,16] JDK-8164597 : TestIOException.java fails after push for JDK-8164130.

2020-06-25 Thread Jonathan Gibbons
Pavel, Thanks for your reasoned explanation. My main objection to this thread is that the code is fairly recent code (2016) that was in 8164130: Simplify doclet IOEException handling and reviewed by both Kumar and Bhavesh. In other words, the code works, is not broken, and it's not worth the

Re: RFR: [test,16] JDK-8164597 : TestIOException.java fails after push for JDK-8164130.

2020-06-25 Thread Jonathan Gibbons
On 6/25/20 11:27 AM, Pavel Rappo wrote: I think that knowing that is superfluous in most cases. If we choose a bigger block (e.g. java.nio.file.Files#copy(java.nio.file.Path, java.nio.file.Path, java.nio.file.CopyOption...)) and capture the implicated files in a DocFileIOException, that coul

Re: RFR: [test,16] JDK-8164597 : TestIOException.java fails after push for JDK-8164130.

2020-06-25 Thread Pavel Rappo
> On 25 Jun 2020, at 19:49, Jonathan Gibbons > wrote: > > Pavel, > > Thanks for your reasoned explanation. > > My main objection to this thread is that the code is fairly recent code > (2016) that was in 8164130: Simplify doclet IOEException handling and > reviewed by both Kumar and Bhave

Re: RFR: [test,16] JDK-8164597 : TestIOException.java fails after push for JDK-8164130.

2020-06-25 Thread Jonathan Gibbons
On 6/25/20 12:16 PM, Pavel Rappo wrote: On 25 Jun 2020, at 19:49, Jonathan Gibbons wrote: Pavel, Thanks for your reasoned explanation. My main objection to this thread is that the code is fairly recent code (2016) that was in 8164130: Simplify doclet IOEException handling and reviewed by