Withdrawn: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-11 Thread Dmitriy Dumanskiy
On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy wrote: > **isEmpty** is faster + has less byte code + easier to read. Benchmarks could > be found > > [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416). This pull request has been closed without

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-11 Thread Dmitriy Dumanskiy
On Thu, 10 Sep 2020 23:57:38 GMT, Phil Race wrote: >> **isEmpty** is faster + has less byte code + easier to read. Benchmarks >> could be found >> >> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416). > > 1) This is un-necessary churn. > 2) I can'

Re: RFR: 8236142: DocTrees should provide getCharacters(EntityTree) [v2]

2020-09-11 Thread Pavel Rappo
On Fri, 11 Sep 2020 03:02:36 GMT, Jonathan Gibbons wrote: >> A new method is added to the `DocTrees` utility class to return the >> characters represented by a named or numeric >> entity, as represented in an `EntityTree`. > > Jonathan Gibbons has updated the pull request incrementally with one

Integrated: 8236142: DocTrees should provide getCharacters(EntityTree)

2020-09-11 Thread Jonathan Gibbons
On Thu, 10 Sep 2020 22:53:42 GMT, Jonathan Gibbons wrote: > A new method is added to the `DocTrees` utility class to return the > characters represented by a named or numeric > entity, as represented in an `EntityTree`. This pull request has now been integrated. Changeset: 7f27d0b0 Author:

Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-11 Thread Bradford Wetmore
On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy wrote: >> 1) This is un-necessary churn. >> 2) I can't even be sure I am finding the ones in my area because there's so >> much here >> 3) The ones I can find have no need of whatever performance improvement this >> might bring. >> I think th

RFR: JDK-8252712: move doclint to jdk.javadoc module

2020-09-11 Thread Jonathan Gibbons
doclint is a component that can check documentation comments, that can be invoked from either javac or javadoc, via the `-Xdoclint` family of options. When JDK was modularized in JDK9, doclint was left in the `jdk.compiler` module because of direct references to the code from javac, even though