[PING] RE: 8157682: @inheritDoc doesn't work with @exception

2021-03-03 Thread yano-masan...@fujitsu.com
Hi Jon, This is a ping. Please tell me the progress of this bug fixing work. Regards, Masanori Yano > -Original Message- > From: Yano, Masanori > Sent: Tuesday, January 12, 2021 4:40 PM > To: 'Jonathan Gibbons' ; > 'javadoc-dev@openjdk.java.net' > Subject: RE: 8157682: @inheritDoc does

RFR: 8261450: JShell crashes with SIOOBE in tab completion

2021-03-03 Thread Jan Lahoda
`reflowTillNow` will strip trailing spaces, but then `reflownTo` may point after the full content of `result`. Need to fix `reflownTo` to not point after the full content of `result`, otherwise a `StringIndexOutOfBoundsException` may occur. - Commit messages: - 8261450: JShell cra

Re: RFR: 8261450: JShell crashes with SIOOBE in tab completion

2021-03-03 Thread Vicente Romero
On Wed, 3 Mar 2021 16:43:02 GMT, Jan Lahoda wrote: > `reflowTillNow` will strip trailing spaces, but then `reflownTo` may point > after the full content of `result`. Need to fix `reflownTo` to not point > after the full content of `result`, otherwise a > `StringIndexOutOfBoundsException` may o

RFR: JDK-8157682: @inheritDoc doesn't work with @exception

2021-03-03 Thread Jonathan Gibbons
Please review a fix to improve the handling of the legacy `@exception` tag. A patch for this was [previously submitted](https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-September/001139.html). However, that patch introduced an explicit new `ExceptionTaglet` class, whereas the fix here j

Re: 8157682: @inheritDoc doesn't work with @exception

2021-03-03 Thread Jonathan Gibbons
Hi, I looked in detail at your patch. I understand the problem you're trying to solve, but this is not the best way to solve the problem. You're introducing a new `ExceptionTaglet` class that provides a subset of the functionality of the equivalent `ThrowsTaglet` class. A better way to so