Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v9]

2021-06-03 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v10]

2021-06-03 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: JDK-8267394: Do not rely on object identity for empty valid Content instance

2021-06-03 Thread Jonathan Gibbons
On Thu, 20 May 2021 14:31:33 GMT, Hannes Wallnöfer wrote: > This is a simple cleanup to replace the sentinel `HtmlTree.EMPTY` text > constant with an instance that achieves the same by overriding `isValid()`. I > think this is the nicer solution, and it allows us to remove the special case > i

Re: RFR: JDK-8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing

2021-06-03 Thread Jonathan Gibbons
On Tue, 1 Jun 2021 16:21:56 GMT, Hannes Wallnöfer wrote: > Removal of ugly old code in `SerializedFormBuilder.java`. Luckily there > already is a clean overloaded method in the associated writer that we can > use, so this is mostly a removal of code that is no longer used. > > I also enhanced

Re: RFR: JDK-8259806: Clean up terminology on the "All Classes" page

2021-06-03 Thread Jonathan Gibbons
On Mon, 31 May 2021 10:06:14 GMT, Hannes Wallnöfer wrote: > This is a simple change to replace the "All Classes" with "All Classes and > Interfaces" in the heading of and references to the page of the same name. Maybe I'm fighting a losing battle on this one, but the current policy is to gener

Re: RFR: JDK-8266748: Move modifiers code to Signatures.java

2021-06-03 Thread Jonathan Gibbons
On Fri, 21 May 2021 08:46:48 GMT, Hannes Wallnöfer wrote: > This change consolidates the code to generate type signature modifiers into > `Signatures.TypeSignature`. > > Although this mostly consists of moving the code from `ClassWriterImpl` and > `Utils` to `Signatures`, I also avoided the n