Re: RFR: JDK-8268352: Rename javadoc Messager class to JavadocLog

2021-06-08 Thread Pavel Rappo
On Tue, 8 Jun 2021 01:23:17 GMT, Jonathan Gibbons wrote: > Please review a simple cleanup, to rename the javadoc Messager class to the > more explicit, less-confusing name of JavadocLog, since it is the javadoc > subtype of the javac Log class. > > The new name is in line with other javadoc su

Re: RFR: JDK-8263468: New page for "recent" new API [v4]

2021-06-08 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 19:48:39 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relatively

Re: RFR: JDK-8259806: Clean up terminology on the "All Classes" page

2021-06-08 Thread Jonathan Gibbons
On Mon, 31 May 2021 10:06:14 GMT, Hannes Wallnöfer wrote: > This is a simple change to replace the "All Classes" with "All Classes and > Interfaces" in the heading of and references to the page of the same name. Marked as reviewed by jjg (Reviewer). - PR: https://git.openjdk.java.

Re: RFR: JDK-8266748: Move modifiers code to Signatures.java [v2]

2021-06-08 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 13:09:24 GMT, Hannes Wallnöfer wrote: >> This change consolidates the code to generate type signature modifiers into >> `Signatures.TypeSignature`. >> >> Although this mostly consists of moving the code from `ClassWriterImpl` and >> `Utils` to `Signatures`, I also avoided t

Re: RFR: JDK-8268352: Rename javadoc Messager class to JavadocLog [v2]

2021-06-08 Thread Jonathan Gibbons
> Please review a simple cleanup, to rename the javadoc Messager class to the > more explicit, less-confusing name of JavadocLog, since it is the javadoc > subtype of the javac Log class. > > The new name is in line with other javadoc subtypes of javac classes. > > The change only affects the j

Re: RFR: JDK-8268352: Rename javadoc Messager class to JavadocLog [v2]

2021-06-08 Thread Pavel Rappo
On Tue, 8 Jun 2021 17:04:37 GMT, Jonathan Gibbons wrote: >> Please review a simple cleanup, to rename the javadoc Messager class to the >> more explicit, less-confusing name of JavadocLog, since it is the javadoc >> subtype of the javac Log class. >> >> The new name is in line with other javad

Integrated: JDK-8268352: Rename javadoc Messager class to JavadocLog

2021-06-08 Thread Jonathan Gibbons
On Tue, 8 Jun 2021 01:23:17 GMT, Jonathan Gibbons wrote: > Please review a simple cleanup, to rename the javadoc Messager class to the > more explicit, less-confusing name of JavadocLog, since it is the javadoc > subtype of the javac Log class. > > The new name is in line with other javadoc su

Integrated: JDK-8263468: New page for "recent" new API

2021-06-08 Thread Hannes Wallnöfer
On Wed, 26 May 2021 16:02:29 GMT, Hannes Wallnöfer wrote: > This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively min

Integrated: JDK-8259806: Clean up terminology on the "All Classes" page

2021-06-08 Thread Hannes Wallnöfer
On Mon, 31 May 2021 10:06:14 GMT, Hannes Wallnöfer wrote: > This is a simple change to replace the "All Classes" with "All Classes and > Interfaces" in the heading of and references to the page of the same name. This pull request has now been integrated. Changeset: 4dd0e7e7 Author:Hannes W

Integrated: JDK-8266748: Move modifiers code to Signatures.java

2021-06-08 Thread Hannes Wallnöfer
On Fri, 21 May 2021 08:46:48 GMT, Hannes Wallnöfer wrote: > This change consolidates the code to generate type signature modifiers into > `Signatures.TypeSignature`. > > Although this mostly consists of moving the code from `ClassWriterImpl` and > `Utils` to `Signatures`, I also avoided the n

RFR: 8264866: Remove unneeded WorkArounds.isAutomaticModule

2021-06-08 Thread Joe Darcy
Simple cleanup as a follow-on to JDK-8264865. Clean langtools test run. - Commit messages: - 8264866: Remove unneeded WorkArounds.isAutomaticModule Changes: https://git.openjdk.java.net/jdk/pull/4417/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4417&range=00 Issue:

Re: RFR: 8264866: Remove unneeded WorkArounds.isAutomaticModule

2021-06-08 Thread Jonathan Gibbons
On Tue, 8 Jun 2021 19:37:28 GMT, Joe Darcy wrote: > Simple cleanup as a follow-on to JDK-8264865. Clean langtools test run. 👍 - Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4417

Integrated: 8264866: Remove unneeded WorkArounds.isAutomaticModule

2021-06-08 Thread Joe Darcy
On Tue, 8 Jun 2021 19:37:28 GMT, Joe Darcy wrote: > Simple cleanup as a follow-on to JDK-8264865. Clean langtools test run. This pull request has now been integrated. Changeset: 7a378165 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/7a37816548b913494b9671df9469b159cc