RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes"

2021-10-21 Thread Hannes Wallnöfer
This is a conceptually simple change to merge the "Exception" and "Error" classes into a single "Exception Class" group. The only change that is not strictly related to the merge is the removal of unused type subsets and related methods in `TypeElementCatalog.java` and the use of `Collections.e

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes"

2021-10-21 Thread Pavel Rappo
On Thu, 21 Oct 2021 09:30:34 GMT, Hannes Wallnöfer wrote: > This is a conceptually simple change to merge the "Exception" and "Error" > classes into a single "Exception Class" group. > > The only change that is not strictly related to the merge is the removal of > unused type subsets and relat

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes"

2021-10-21 Thread Hannes Wallnöfer
On Thu, 21 Oct 2021 11:17:31 GMT, Pavel Rappo wrote: >> This is a conceptually simple change to merge the "Exception" and "Error" >> classes into a single "Exception Class" group. >> >> The only change that is not strictly related to the merge is the removal of >> unused type subsets and relat

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-21 Thread Hannes Wallnöfer
> This is a conceptually simple change to merge the "Exception" and "Error" > classes into a single "Exception Class" group. > > The only change that is not strictly related to the merge is the removal of > unused type subsets and related methods in `TypeElementCatalog.java` and the > use of `C

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-21 Thread Hannes Wallnöfer
On Thu, 21 Oct 2021 11:09:10 GMT, Pavel Rappo wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8269401: Include Throwable in exception classes > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/f

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v3]

2021-10-21 Thread Ichiroh Takiguchi
On Tue, 19 Oct 2021 01:26:35 GMT, Jonathan Gibbons wrote: >> Ichiroh Takiguchi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274544: Langtools command's usage were garbled on Japanese Windows > > This is pretty ugly code to be replica

RFR: JDK-8275199: Bogus warning generated for serializable records

2021-10-21 Thread Jonathan Gibbons
Please review a trivial fix and simple test for DocLint and serializable records. Although the original JBS issue was somewhat confused, the underlying cause of the test case is that `javadoc`/`DocLint` was checking the comments on the private internal fields, prior to writing the fields in the

Re: RFR: JDK-8275199: Bogus warning generated for serializable records

2021-10-21 Thread Jonathan Gibbons
On Fri, 22 Oct 2021 00:12:04 GMT, Jonathan Gibbons wrote: > Please review a trivial fix and simple test for DocLint and serializable > records. > > Although the original JBS issue was somewhat confused, the underlying cause > of the test case is that `javadoc`/`DocLint` was checking the commen

Re: RFR: JDK-8275199: Bogus warning generated for serializable records [v2]

2021-10-21 Thread Jonathan Gibbons
> Please review a trivial fix and simple test for DocLint and serializable > records. > > Although the original JBS issue was somewhat confused, the underlying cause > of the test case is that `javadoc`/`DocLint` was checking the comments on the > private internal fields, prior to writing the f