Re: RFR: JDK-8282214: Upgrade JQuery to version 3.6.0

2022-03-14 Thread Jonathan Gibbons
On Fri, 4 Mar 2022 14:12:11 GMT, Hannes Wallnöfer wrote: > This is a straightforward change to update the jQuery library used in javadoc > to version 3.6.0. > > Both compressed and uncompressed versions of jQuery 3.6.0 were downloaded > from https://jquery.com/download/ to replace the old ver

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-14 Thread Alisen Chung
On Thu, 10 Mar 2022 18:56:41 GMT, Chris Plummer wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> moved CurrencyNames changes to jdk.localedata > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResourc

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-14 Thread Alexander Zuev
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata Marked as reviewed by kizune (Reviewer)

Re: RFR: JDK-8268866: Javascript when used in an iframe cannot display search results

2022-03-14 Thread Jonathan Gibbons
On Wed, 23 Feb 2022 16:23:04 GMT, Hannes Wallnöfer wrote: > Please review a trivial fix to make javadoc search work inside an `iframe`. > The fix consists in removing old code that probably stems from back when > javadoc used frames and doesn't work with generic iframes. > > With the fix appl

Re: RFR: JDK-8282214: Upgrade JQuery to version 3.6.0 [v2]

2022-03-14 Thread Hannes Wallnöfer
> This is a straightforward change to update the jQuery library used in javadoc > to version 3.6.0. > > Both compressed and uncompressed versions of jQuery 3.6.0 were downloaded > from https://jquery.com/download/ to replace the old version and all > references in javadoc src and test code wer

Re: RFR: JDK-8282214: Upgrade JQuery to version 3.6.0 [v2]

2022-03-14 Thread Hannes Wallnöfer
On Mon, 14 Mar 2022 16:30:10 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> One more version to update > > src/jdk.javadoc/share/legal/jquery.md line 5: > >> 3: ### jQuery License >> 4:

Re: RFR: JDK-8268335: Find better way to exclude empty HTML elements [v5]

2022-03-14 Thread Jonathan Gibbons
On Mon, 14 Mar 2022 18:16:01 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Introduce Content.isDiscardable() > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/S

Re: RFR: JDK-8268335: Find better way to exclude empty HTML elements [v5]

2022-03-14 Thread Jonathan Gibbons
On Tue, 22 Feb 2022 14:46:27 GMT, Hannes Wallnöfer wrote: >> Please review a change to straighten out the mechanism to avoid generating >> empty HTML elements in javadoc. >> >> Currently this is implemented using the `Content.isValid()` method in >> `HtmlTree.add(Content)` to check whether th

Integrated: JDK-8282214: Upgrade JQuery to version 3.6.0

2022-03-14 Thread Hannes Wallnöfer
On Fri, 4 Mar 2022 14:12:11 GMT, Hannes Wallnöfer wrote: > This is a straightforward change to update the jQuery library used in javadoc > to version 3.6.0. > > Both compressed and uncompressed versions of jQuery 3.6.0 were downloaded > from https://jquery.com/download/ to replace the old ver

Integrated: JDK-8268866: Javascript when used in an iframe cannot display search results

2022-03-14 Thread Hannes Wallnöfer
On Wed, 23 Feb 2022 16:23:04 GMT, Hannes Wallnöfer wrote: > Please review a trivial fix to make javadoc search work inside an `iframe`. > The fix consists in removing old code that probably stems from back when > javadoc used frames and doesn't work with generic iframes. > > With the fix appl

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]

2022-03-14 Thread Alisen Chung
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed repeated lines from ROOT bundle in CurrencyNames - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new: htt

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]

2022-03-14 Thread Naoto Sato
On Mon, 14 Mar 2022 20:39:46 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed repeated lines from ROOT bundle in CurrencyNames src/jdk.compiler/share/class