Re: [External] : Re: external snippets

2022-03-23 Thread Jonathan Gibbons
Anna, For javadoc itself, the intent is that you should not need to do anything else to have javadoc detect the `snippet-files` directory and to incorporate the content into the documentation.  You can verify that by manually running a javadoc command on the example files you have set up. Ho

RFR: 8275727: Tests may fail with zh locale on MacOS

2022-03-23 Thread Vikey Chen
I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en -Duser.country=US"`, some tests still fail because of default locale, Most of them are langtools tests. On MacOS 12.1. - Commit messages: - Tests may fail with zh locale on MacOS Changes: https://git.openjdk.java

Re: RFR: 8275727: Tests may fail with zh locale on MacOS

2022-03-23 Thread Vikey Chen
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. Can somebody create an issue for me. I've re

Re: RFR: 8275727: Tests may fail with zh locale on MacOS

2022-03-23 Thread David Holmes
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. It is not clear to me why only the listed te

Re: [External] : Re: external snippets

2022-03-23 Thread Anna Kozlova
Hi Jonathan, how should IDE(A) pass the content of `snippet-files` to the javadoc, javac, etc? I hope I'll be able to fix that so users will be able to use the simple way of defining external snippets. Thanks Anna On Tue, Mar 22, 2022 at 3:31 PM Jonathan Gibbons < jonathan.gibb...@oracle.com> wro

Re: [External] : Re: external snippets

2022-03-23 Thread Anna Kozlova
Jonathan, IDEA runs javadoc tool as following `javadoc -d output -classpath project_classpath project_name/src/p/Main.java`. I can change this if I would understand what should be placed instead. I am sorry for not being able to understand myself Thanks, Anna On Wed, Mar 23, 2022 at 3:48 PM Jon

Re: [External] : Re: external snippets

2022-03-23 Thread Jonathan Gibbons
Anna, Maybe it was a typo but that command does not correspond to the file layout you described earlier. The command is missing the `main/java/` part. I don't know what `project_classpath` is in your case. If it is just the (output) classes directory, you might try adding a sourcepath option,

Re: RFR: 8275727: Tests may fail with zh locale on MacOS

2022-03-23 Thread Vikey Chen
On Thu, 24 Mar 2022 00:53:26 GMT, David Holmes wrote: >> I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en >> -Duser.country=US"`, some tests still fail because of default locale, Most >> of them are langtools tests. >> >> On MacOS 12.1. > > It is not clear to me why only the

Re: RFR: 8275727: Tests may fail with zh locale on MacOS

2022-03-23 Thread David Holmes
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > I have run tier-1 test with `JTREG="VM_OPTIONS=-Duser.language=en > -Duser.country=US"`, some tests still fail because of default locale, Most of > them are langtools tests. > > On MacOS 12.1. I have filed: https://bugs.openjdk.java.net