On Thu, 24 Mar 2022 14:06:03 GMT, Roger Riggs wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
On Fri, 25 Mar 2022 04:27:55 GMT, Jonathan Gibbons wrote:
> Please review a (mostly) resource-file change to improve the message when the
> file for an external snippet cannot be found.
>
> Previously, the code (re)used an existing resource, "File not found". This
> resource was used in conjun
On Wed, 16 Mar 2022 16:32:09 GMT, Pavel Rappo wrote:
> This PR started in a draft mode as a refactoring effort. After a few commits
> and chats with Jonathan Gibbons, I decided that further refactoring belongs
> to follow-up PRs and that this PR could be marked as "Ready for review".
>
> The m
On Wed, 16 Mar 2022 16:32:09 GMT, Pavel Rappo wrote:
> This PR started in a draft mode as a refactoring effort. After a few commits
> and chats with Jonathan Gibbons, I decided that further refactoring belongs
> to follow-up PRs and that this PR could be marked as "Ready for review".
>
> The m
This PR started in a draft mode as a refactoring effort. After a few commits
and chats with Jonathan Gibbons, I decided that further refactoring belongs to
follow-up PRs and that this PR could be marked as "Ready for review".
The motivation for the initial refactoring effort was as follows. The
On Wed, 16 Mar 2022 16:47:12 GMT, Jonathan Gibbons wrote:
>> This PR started in a draft mode as a refactoring effort. After a few commits
>> and chats with Jonathan Gibbons, I decided that further refactoring belongs
>> to follow-up PRs and that this PR could be marked as "Ready for review".
>>
On Mon, 21 Mar 2022 18:21:14 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
>> line 222:
>>
>>> 220:
>>> 221: /**
>>> 222: * Get the class inheritance tree for the given class.
>>
>> * Gets
>>
>> "class inherit
On Wed, 16 Mar 2022 16:59:22 GMT, Jonathan Gibbons wrote:
>> This PR started in a draft mode as a refactoring effort. After a few commits
>> and chats with Jonathan Gibbons, I decided that further refactoring belongs
>> to follow-up PRs and that this PR could be marked as "Ready for review".
>>
On Mon, 21 Mar 2022 18:29:59 GMT, Jonathan Gibbons wrote:
>> I picked "inheritance" over "hierarchy" for consistency, because the
>> relevant entities in HTML and CSS referred to "inheritance"; for example:
>>
>> *
>> jdk/javadoc/internal/doclets/formats/html/resources/standard.properties:164
On Mon, 21 Mar 2022 18:53:20 GMT, Pavel Rappo wrote:
>> Yes, my criticism was about the use of the word "tree" in this case. While I
>> agree that this is not the primary use you are trying to eliminate (i.e.
>> HtmlTree-like trees) it nevertheless is misleading to describe the
>> superclasse
On Wed, 23 Mar 2022 10:49:24 GMT, Pavel Rappo wrote:
>> Does your comment mean that we should similarly refine (later) the term
>> "Inheritance Tree"?
>>
>> To make sure we're on the same page, that method (whose doc comment we are
>> talking about) is in charge of producing a small tree-like
On Fri, 25 Mar 2022 10:46:27 GMT, Pavel Rappo wrote:
>> Please review a (mostly) resource-file change to improve the message when
>> the file for an external snippet cannot be found.
>>
>> Previously, the code (re)used an existing resource, "File not found". This
>> resource was used in conjun
On Thu, 24 Mar 2022 14:51:25 GMT, Jonathan Gibbons wrote:
>> Is there a suitable term we could use to describe this _ancestry_
>> information? We are specifically interested in a superclass-subclass chain
>> that connects a class in question with java.lang.Object.
>
> `class hierarchy` ?
> `sup
On Fri, 25 Mar 2022 04:27:55 GMT, Jonathan Gibbons wrote:
> Please review a (mostly) resource-file change to improve the message when the
> file for an external snippet cannot be found.
>
> Previously, the code (re)used an existing resource, "File not found". This
> resource was used in conjun
On Wed, 16 Mar 2022 16:32:09 GMT, Pavel Rappo wrote:
> This PR started in a draft mode as a refactoring effort. After a few commits
> and chats with Jonathan Gibbons, I decided that further refactoring belongs
> to follow-up PRs and that this PR could be marked as "Ready for review".
>
> The m
On Fri, 25 Mar 2022 15:09:02 GMT, Pavel Rappo wrote:
>> `class hierarchy` ?
>> `superclass chain` ?
>> `superclasses` ?
>> `inheritance chain` ?
>> `list of superclasses` ?
>> `ancestors` ?
>> `inheritance list` ?
>> `superclass list` ?
>>
>>
>>
>> 'inheritance` isn't a bad word, it just doesn
On Wed, 16 Mar 2022 16:32:09 GMT, Pavel Rappo wrote:
> This PR started in a draft mode as a refactoring effort. After a few commits
> and chats with Jonathan Gibbons, I decided that further refactoring belongs
> to follow-up PRs and that this PR could be marked as "Ready for review".
>
> The m
On Fri, 25 Mar 2022 04:27:55 GMT, Jonathan Gibbons wrote:
> Please review a (mostly) resource-file change to improve the message when the
> file for an external snippet cannot be found.
>
> Previously, the code (re)used an existing resource, "File not found". This
> resource was used in conjun
18 matches
Mail list logo
