Integrated: 8284908: Refine diagnostic positions for DCErroneous

2022-04-21 Thread Pavel Rappo
On Fri, 15 Apr 2022 16:58:55 GMT, Pavel Rappo wrote: > Before: > > Standard Doclet version 18+36-2087 > Building tree for all the packages and classes... > Generating /tmp/whatever/ExampleDiagnostics.html... > ExampleDiagnostics.java:5: error: unexpected content > * {@docRoot a} >^

RFR: 8285396: Do not fill in the stacktrace of an internal exception

2022-04-21 Thread Pavel Rappo
Sometimes an exception is retrofitted into control flow to interrupt it in a way that it wasn't originally designed to be interrupted. Such an exception is an implementation detail. Once the exception is caught internally, it is discarded. An exception has a stacktrace. Filling in a stacktrace

Re: RFR: 8285396: Do not fill in the stacktrace of an internal exception

2022-04-21 Thread Jonathan Gibbons
On Thu, 21 Apr 2022 19:28:08 GMT, Pavel Rappo wrote: > Sometimes an exception is retrofitted into control flow to interrupt it in a > way that it wasn't originally designed to be interrupted. Such an exception > is an implementation detail. Once the exception is caught internally, it is > disc

Re: RFR: 8285396: Do not fill in the stacktrace of an internal exception

2022-04-21 Thread Pavel Rappo
On Thu, 21 Apr 2022 20:34:31 GMT, Jonathan Gibbons wrote: > The changes for the `UncheckedIOException` wrappers look OK, but might be > even better if the code properly unwrapped the wrapper and simply rethrew the > underlying cause. For example, > > replace > > ``` > } catch (Uncheck

Re: RFR: 8285396: Do not fill in the stacktrace of an internal exception [v2]

2022-04-21 Thread Pavel Rappo
On Thu, 21 Apr 2022 22:10:36 GMT, Pavel Rappo wrote: > The changes for the `UncheckedIOException` wrappers look OK, but might be > even better if the code properly unwrapped the wrapper and simply rethrew the > underlying cause. For example, > > replace > > ``` > } catch (UncheckedIOE

Re: RFR: 8285396: Do not fill in the stacktrace of an internal exception [v2]

2022-04-21 Thread Pavel Rappo
> Sometimes an exception is retrofitted into control flow to interrupt it in a > way that it wasn't originally designed to be interrupted. Such an exception > is an implementation detail. Once the exception is caught internally, it is > discarded. > > An exception has a stacktrace. Filling in a