Re: RFR: JDK-8285939: javadoc java.lang.Record should not have "Direct Known Subclasses:" section

2022-05-04 Thread Pavel Rappo
On Tue, 3 May 2022 20:38:44 GMT, Jonathan Gibbons wrote: > As described in the JBS issue, the observed problem is a side-effect of a > related but different issue, which is that record classes are not treated the > same was as enum classes when it comes to generating the class hierarchy in > `

Re: RFR: JDK-8285869: Selective cleanup in doclint Checker class [v3]

2022-05-04 Thread Pavel Rappo
On Tue, 3 May 2022 22:47:49 GMT, Jonathan Gibbons wrote: >> Please review some localized cleanup for the doclint Checker class, >> primarily focused on upgrading to the use of "enhanced `switch`" >> >> The output of one test was changed because of some improvements in one >> switch statement t

Integrated: JDK-8285869: Selective cleanup in doclint Checker class

2022-05-04 Thread Jonathan Gibbons
On Fri, 29 Apr 2022 00:29:50 GMT, Jonathan Gibbons wrote: > Please review some localized cleanup for the doclint Checker class, primarily > focused on upgrading to the use of "enhanced `switch`" > > The output of one test was changed because of some improvements in one switch > statement to el

Re: RFR: 8285470: Improve handling of @inheritDoc [v4]

2022-05-04 Thread Jonathan Gibbons
On Tue, 3 May 2022 19:30:01 GMT, Pavel Rappo wrote: >> The only taglet that along with its own tag needs to know the immediately >> enclosing tag is `InheritDocTaglet`: >> >> @return {@inheritDoc} >> @throws NullPointerException {@inheritDoc} >> @param p {@inheritDoc} >> >> However

Re: RFR: JDK-8282559: Allow multiple search terms in javadoc search [v3]

2022-05-04 Thread Jonathan Gibbons
On Tue, 19 Apr 2022 12:45:18 GMT, Hannes Wallnöfer wrote: >> Please review the first of two PRs to enhance JavaDoc search. >> >> This one focuses on the existing search script, to which it adds the feature >> to search for multiple terms. It also improves the implementation of >> case-sensiti

Re: RFR: JDK-8248863: Add search landing page to API documentation [v3]

2022-05-04 Thread Jonathan Gibbons
On Tue, 19 Apr 2022 21:04:04 GMT, Hannes Wallnöfer wrote: >> This is the second of two PRs to enhance JavaDoc search, it is based on the >> first one (#8185). >> >> It adds a standalone search page (search.html) along with its own script >> file (search-page.js). This PR is very similar to the

Re: RFR: 8285470: Improve handling of @inheritDoc [v4]

2022-05-04 Thread Pavel Rappo
On Tue, 3 May 2022 19:30:01 GMT, Pavel Rappo wrote: >> The only taglet that along with its own tag needs to know the immediately >> enclosing tag is `InheritDocTaglet`: >> >> @return {@inheritDoc} >> @throws NullPointerException {@inheritDoc} >> @param p {@inheritDoc} >> >> However

Integrated: 8285470: Improve handling of @inheritDoc

2022-05-04 Thread Pavel Rappo
On Fri, 22 Apr 2022 14:05:44 GMT, Pavel Rappo wrote: > The only taglet that along with its own tag needs to know the immediately > enclosing tag is `InheritDocTaglet`: > > @return {@inheritDoc} > @throws NullPointerException {@inheritDoc} > @param p {@inheritDoc} > > However, the i

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-05-04 Thread Ioi Lam
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>

Integrated: 8283606: Tests may fail with zh locale on MacOS

2022-05-04 Thread Vikey Chen
On Wed, 23 Mar 2022 15:34:43 GMT, Vikey Chen wrote: > From the test doc of openjdk > https://openjdk.java.net/groups/build/doc/testing.html >> If your locale is non-US, some tests are likely to fail. To work around this >> you can set the locale to US. On Unix platforms simply setting LANG="en_

RFR: JDK-8286153: Remove redundant casts and other cleanup

2022-05-04 Thread Jonathan Gibbons
Please review some cleanup updates to address issues reported by an IDE. The seeds for the change were a series of redundant casts, that have now all been removed. Various other warnings and suggestions were made by the IDE for the affected files. There were a number of places with redundant ty

Re: RFR: 8283606: Tests may fail with zh locale on MacOS [v4]

2022-05-04 Thread Vikey Chen
On Mon, 28 Mar 2022 17:00:39 GMT, Vikey Chen wrote: >> From the test doc of openjdk >> https://openjdk.java.net/groups/build/doc/testing.html >>> If your locale is non-US, some tests are likely to fail. To work around >>> this you can set the locale to US. On Unix platforms simply setting >>>