RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Alexey Ivanov
Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the… It's the last issue in the series, and it still touches different areas of the code. - Commit messages: - 8284209: Replace remaining usages of 'the a' in source code - 8284209: Replac

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Lance Andersen
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by lancea (Reviewer).

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Bradford Wetmore
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Looked at -java.security.jgss. LGTM --

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Daniel Fuchs
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Logging/JNDI OK - Marked as revi

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer). --

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v2]

2022-05-18 Thread Jonathan Gibbons
> Please review the code and tests to add support for a new `@spec url title` > tag to javadoc. Note, this does not include any changes to API doc comments > to use the new tag in JDK API documentation; that will come later. Jonathan Gibbons has updated the pull request with a new target base d

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v3]

2022-05-18 Thread Jonathan Gibbons
> Please review the code and tests to add support for a new `@spec url title` > tag to javadoc. Note, this does not include any changes to API doc comments > to use the new tag in JDK API documentation; that will come later. Jonathan Gibbons has updated the pull request incrementally with one a

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v3]

2022-05-18 Thread Jonathan Gibbons
On Tue, 3 May 2022 13:52:27 GMT, Pavel Rappo wrote: > This is nice work. I haven't seen it in detail, but I'm plannig to do so > later. > > What's the logistics here? There are two interrelated bugs: 6251738 and > 8226279. Are you going to add an 8226279 as an issue to this PR (`/issue add >

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v3]

2022-05-18 Thread Jonathan Gibbons
On Tue, 3 May 2022 21:58:29 GMT, Jonathan Gibbons wrote: >> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeFactory.java line >> 340: >> >>> 338: SnippetTree newSnippetTree(List attributes, >>> TextTree text); >>> 339: >>> 340: /** >> >> Similar comment to that of DocTreeVi

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v4]

2022-05-18 Thread Jonathan Gibbons
> Please review the code and tests to add support for a new `@spec url title` > tag to javadoc. Note, this does not include any changes to API doc comments > to use the new tag in JDK API documentation; that will come later. Jonathan Gibbons has updated the pull request incrementally with one a

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Jonathan Gibbons
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. javac and javadoc changes look OK test/langto