Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-10-09 Thread Nizar Benalla
On Mon, 19 Aug 2024 16:35:29 GMT, Nizar Benalla wrote: >> Can I please get a review for this simple change? It's an attempt to improve >> the code example in doclet package. >> Here are the generated docs with the [new code >> example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletEx

Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-08-30 Thread Jonathan Gibbons
On Mon, 19 Aug 2024 16:35:29 GMT, Nizar Benalla wrote: >> Can I please get a review for this simple change? It's an attempt to improve >> the code example in doclet package. >> Here are the generated docs with the [new code >> example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletEx

Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-08-30 Thread Jonathan Gibbons
On Fri, 30 Aug 2024 13:34:23 GMT, Nizar Benalla wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/doclet/package-info.java line 289: >> >>> 287: * >>> 288: *// A scanner to loop through specified elements >>> 289: *class ShowFileObjects { >> >> What is the benefit of defining this

Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-08-30 Thread Nizar Benalla
On Fri, 30 Aug 2024 08:22:30 GMT, Hannes Wallnöfer wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename SimpleDoclet to Example so that TestDocletExample.java passes > > src/jdk.javadoc/share/classes/jdk/javadoc

Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-08-30 Thread Hannes Wallnöfer
On Mon, 19 Aug 2024 16:35:29 GMT, Nizar Benalla wrote: >> Can I please get a review for this simple change? It's an attempt to improve >> the code example in doclet package. >> Here are the generated docs with the [new code >> example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletEx

Re: RFR: 8333230: Improve code example in doclet package [v2]

2024-08-19 Thread Nizar Benalla
> Can I please get a review for this simple change? It's an attempt to improve > the code example in doclet package. > Here are the generated docs with the [new code > example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletExample/api/jdk.javadoc/jdk/javadoc/doclet/package-summary.html

RFR: 8333230: Improve code example in doclet package

2024-08-16 Thread Nizar Benalla
Can I please get a review for this simple change? It's an attempt to improve the code example in doclet package. Here are the generated docs with the [new code example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletExample/api/jdk.javadoc/jdk/javadoc/doclet/package-summary.html#Example