Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-17 Thread SendaoYan
On Wed, 16 Apr 2025 17:59:18 GMT, Nizar Benalla wrote: >> Hi all, >> >> The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java >> javac build fails. This PR add depedencies to make javac build success. >> Test-fix only, change has been verified locally, no risk. > > Thank y

Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-17 Thread SendaoYan
On Thu, 17 Apr 2025 09:55:41 GMT, Jaikiran Pai wrote: > Hello @sendaoYan, can you share the command that you used to launch these > tests? We haven't noticed this compilation error in our CI yet. So although > the proposed change looks reasonable, it would be good to understand why this > hasn

Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-17 Thread Jaikiran Pai
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote: > Hi all, > > The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java > javac build fails. This PR add depedencies to make javac build success. > Test-fix only, change has been verified locally, no risk. Hello @sendaoYan, c

Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-17 Thread Jaikiran Pai
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote: > Hi all, > > The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java > javac build fails. This PR add depedencies to make javac build success. > Test-fix only, change has been verified locally, no risk. Marked as reviewed

Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-17 Thread Nizar Benalla
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote: > Hi all, > > The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java > javac build fails. This PR add depedencies to make javac build success. > Test-fix only, change has been verified locally, no risk. This looks good. -

Re: RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-16 Thread Nizar Benalla
On Wed, 16 Apr 2025 04:03:24 GMT, SendaoYan wrote: > Hi all, > > The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java > javac build fails. This PR add depedencies to make javac build success. > Test-fix only, change has been verified locally, no risk. Thank you Sendao, I

RFR: 8354766: Test TestUnexported.java javac build fails

2025-04-15 Thread SendaoYan
Hi all, The newly added test jdk/javadoc/doclet/testUnexported/TestUnexported.java javac build fails. This PR add depedencies to make javac build success. Test-fix only, change has been verified locally, no risk. - Commit messages: - 8354766: Test TestUnexported.java javac build f